Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to Application Layer - User Updating Application #22

Closed
Buwujiu opened this issue Nov 6, 2024 · 1 comment · Fixed by #80
Closed

Add to Application Layer - User Updating Application #22

Buwujiu opened this issue Nov 6, 2024 · 1 comment · Fixed by #80
Assignees
@demariadaniel
Milestone
4 - Application M...

Comments

@Buwujiu
Copy link
Contributor

Buwujiu commented Nov 6, 2024 •
edited
Loading

Descriptions

In order to allow users to update applications, we need functions to implement these rules:

  1. When can applications be updated?
    Applicants can update application content in these status:
  • Draft
  • Rep Review
  • DAC Review
  1. What can be updated?
    All sections from Applicant Information to Sign & Submit can be updated by the applicants.
  2. When an application is under Rep Review or DAC Review and applications choose to update the content, the application status will be changed to "Draft" state.

State Diagram: https://app.diagrams.net/#G1BjtTpNjSG-GZ16cRhNxVMO66Nb-orq8A#%7B%22pageId%22%3A%22_lPtPaqGYKIoLKm9CYdD%22%7D

Acceptance Criteria
@Buwujiu Buwujiu changed the title User Updating Application Add to Application Layer - User Updating Application Nov 7, 2024
@Buwujiu
Copy link
Contributor Author

Buwujiu commented Nov 19, 2024

Depends on PR #40

@demariadaniel demariadaniel mentioned this issue Nov 19, 2024
Closed
@Buwujiu Buwujiu linked a pull request Nov 20, 2024 that will close this issue
WIP: Feat/22 User Application updates #66
Closed
@demariadaniel demariadaniel linked a pull request Dec 2, 2024 that will close this issue
✏️ Feat/ #22 Application Update methods #80
Merged
6 tasks
@demariadaniel demariadaniel mentioned this issue Dec 2, 2024
Merged
6 tasks
demariadaniel added a commit that referenced this issue Dec 4, 2024
@demariadaniel
✏️ Feat/ #22 Application Update methods (#80)
391846c 
* Service Edit method

* Move Test Files

* Use .test naming convention

* Move API test file

* Tests for Edit Method

* Remove npx

* DBml / schema updates

* Use dist folder for config, add first readme update

* Setup Router & API + Move logic out of service

* Working API Test w/ some reorg

* Edit for clarity

* Remove Demo endpoint

* Route + service improvements

* Add todo

* Move service type, add error condition

* First updates with success/failure

* Move tests

* Use Success/Failure pattern with getById

* Add TSDoc

* Add getDbInstance type

* Throw err is no db instance

* Add body parser

* Simplify variable declaration

* Add Comments + Transaction

* Print error message in response

* Remove tests from tsconfig

* Add Edit endpoint to Swagger w/ 404

* Add Error Todo
@Buwujiu Buwujiu mentioned this issue Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@demariadaniel demariadaniel

Labels
None yet
Projects
None yet
Milestone
4 - Application Management Backend
2 participants
@Buwujiu @demariadaniel