Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163: Collaborator Validation For Add Modal #182

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

JamesTLopez
Copy link
Contributor

@JamesTLopez JamesTLopez commented Feb 3, 2025

Summary

Implementation of the Add Modal and the validation for the form.

Related Issues

Description of Changes

  • UI implementation of the Add Modal in the collaborator view
    • Functional open and close state
  • Add Collaborator Schema in the Validation package
  • Add translations

Special Instructions

Before running these changes, you will need to install the updated changes to the validation pacakge.

Please run the following command in the top level folder:

pnpm build:all

Readiness Checklist

  • Self Review

    • I have performed a self review of code
    • I have run the application locally and manually tested the feature
  • PR Format

    • The PR title is properly formatted to match the pattern: #{TicketNumber}: Description of Changes
    • Links are included to all relevant tickets
  • Labels Added

    • Label is added for each package/app that is modified (api, ui, data-model, etc.)
    • Label is added for the type of work done in this PR (feature, fix, chore, documentation)
  • Local Testing

    • Successfully built all packages locally
    • Successfully ran all test suites, all unit and integration tests pass
  • Updated Tests

    • Unit and integration tests have been added that describe the bug that was fixed or the features that were added
      image
  • Documentation

    • All new environment variables added to .env.schema file and documented in the README
    • All changes to server HTTP endpoints have open-api documentation
    • All new functions exported from their module have TSDoc comment documentation

@JamesTLopez JamesTLopez marked this pull request as ready for review February 3, 2025 15:32
Copy link
Member

@surajgoraya surajgoraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Really straight forward!

@JamesTLopez JamesTLopez merged commit 10cdbd9 into main Feb 5, 2025
@JamesTLopez JamesTLopez deleted the feat/163-validation-collaborator branch February 5, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants