Fix bookmark character name not being outputted

ParadoxGameConverters · Jan 20, 2025 · 6412969 · 6412969
1 parent 3e3ddee
commit 6412969
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/ImperatorToCK3/CK3/Localization/CK3LocBlock.cs b/ImperatorToCK3/CK3/Localization/CK3LocBlock.cs
@@ -36,7 +36,7 @@ public void CopyFrom(LocBlock otherBlock) {
 
 	public void CopyFrom(CK3LocBlock otherBlock) {
 		foreach (var (language, loc) in otherBlock.localizations) {
-			localizations[language] = loc;
+			localizations[language] = (loc.Item1, CK3LocType.ConverterGenerated);
 		}
 	}
 

diff --git a/ImperatorToCK3/Outputter/BookmarkOutputter.cs b/ImperatorToCK3/Outputter/BookmarkOutputter.cs
@@ -83,13 +83,14 @@ Configuration config
 
 		// Add character localization for bookmark screen.
 		var holderLoc = ck3LocDB.GetOrCreateLocBlock($"bm_converted_{holder.Id}");
-		if (holder.GetName(config.CK3BookmarkDate) is {} holderName) {
-			if (ck3LocDB.TryGetValue(holderName, out var holderNameLoc)) {
+		string? holderNameKey = holder.GetName(config.CK3BookmarkDate);
+		if (holderNameKey is not null) {
+			if (ck3LocDB.TryGetValue(holderNameKey, out var holderNameLoc)) {
 				holderLoc.CopyFrom(holderNameLoc);
 			} else {
-				// Use the raw name.
+				// Use the raw name key.
 				foreach (var language in ConverterGlobals.SupportedLanguages) {
-					holderLoc[language] = holderName;
+					holderLoc[language] = holderNameKey;
 				}
 			}
 		}