Check if RQ_DASHBOARD_REDIS_URL is already populated #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RQ_DASHBOARD_REDIS_URL is getting repopulated with the default value when using RQ_DASHBOARD_SETTINGS option for giving path to config file.
cjlapao
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RQ_DASHBOARD_REDIS_URL is getting repopulated after make_flask_app() method call with the default value when using RQ_DASHBOARD_SETTINGS option for giving path to config file.
Fixes # (issue)
Added a NULL check for app.config["RQ_DASHBOARD_REDIS_URL"] before populating it with redis_url or default value
Type of change
Please delete options that are not relevant.
Checklist:
Please let me know where I need to upload the CHANGELOG.md, I do not see it in the repo