This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Fix target=_blank bug #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A link with target=_blank was not opening in a new tab.
|
@Paratron Could you review the PR? |
Paratron
approved these changes
Dec 1, 2020
|
Merged! Interesting that no one catched this before :D |
|
Thank you 🙏 |
|
This commit introduces a syntax error (two close parens) on line Link.js:22. |
ogazitt
added a commit
to ogazitt/hookrouter
that referenced
this pull request
Dec 21, 2020
A previous commit (linked to Paratron#146) inserted an extra ')' to close the if statement, leading to a syntax error. This very simple commit fixes it.
prageeth
reviewed
Jan 24, 2021
| @@ -19,7 +19,7 @@ import {navigate, getBasepath} from "./router"; | |||
| */ | |||
| export const setLinkProps = (props) => { | |||
| const onClick = (e) => { | |||
| if (!e.shiftKey && !e.ctrlKey && !e.altKey) { | |||
| if (!e.shiftKey && !e.ctrlKey && !e.altKey && props.target !== "_blank")) { | |||
There was a problem hiding this comment.
@tugceakin Seems like you accidentally added an extra closing parantheses here ).
There was a problem hiding this comment.
@ogazitt Sorry I should have looked around. I only noticed it when i was fixing my issue with the ForwardRefs in Material UI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected
target=_blankattribute opens the linked document in a new window or tabActual
target=_blankdoesn't change the behavior of the link.