Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add a new struct called
CompactCowStr
to incorporate Cow forCompactString
.This proposal has been previously discussed in issue #223.
Question
Reuse of
Repr
:CompactCowStr
reusesRepr
, which may potentially impactCompactString
.If
Cow
flag ofLastUtf8Char
leaked toCompactString
, this might cause UB.Methods:
Which methods equivalent to those in
CompactString
are necessary forCompactCowStr
?Inlining:
For the new method, should we inline it?
Name Discussion:
Previous pull request suggested the name
CompactCow
, but considering its relationship to String, I have changed it toCompactCowStr
.