This repository has been archived by the owner on Jun 2, 2020. It is now read-only.
Snaji/create persipubsub #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radomsak
reviewed
Jan 29, 2019
slimeth
force-pushed
the
snaji/create-persipubsub
branch
2 times, most recently
from
73e0c51 to
9b9a710
Compare
slimeth
force-pushed
the
snaji/create-persipubsub
branch
from
9b9a710 to
e41f3cd
Compare
radomsak
reviewed
Feb 6, 2019
There was a problem hiding this comment.
Review part 1
-
You need to decide whether publisher sends messages to the subscriber, or maybe it only writes messages to the queue and then subscriber read them. Once you make up your mind you should make sure that all the comments are consistent (some of my suggestions might not apply then)
-
Please explain what exactly happens in get_queue_data function offline. Maybe there is a way to not have this function
radomsak
reviewed
Feb 6, 2019
There was a problem hiding this comment.
Hi Selim,
The code looks really good! There are only minor comments and changes. You did great work.
I reviewed up to tests. More comes tomorrow afternoon
Two comments for now
- You need to decide whether publisher sends messages to the subscriber, or maybe it only writes messages to the queue and then subscriber read them. Once you make up your mind you should make sure that all the comments are consistent (some of my suggestions might not apply then)
- Please explain what exactly happens in get_queue_data function offline. Maybe there is a way to not have this function
Adam
radomsak
reviewed
Feb 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.