Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue/feature templates #1339

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Update issue/feature templates #1339

merged 4 commits into from
Oct 8, 2019

Conversation

yadudoc
Copy link
Member

@yadudoc yadudoc commented Oct 8, 2019

No description provided.

@yadudoc
Copy link
Member Author

yadudoc commented Oct 8, 2019

Tagging @dgasmith for comments since he recommended we add templates for issues features.

@dgasmith
Copy link
Contributor

dgasmith commented Oct 8, 2019

You can find ours here. A nice example as well.

@dgasmith
Copy link
Contributor

dgasmith commented Oct 8, 2019

Whoops, thought this was an issue! Reading now.

dgasmith
dgasmith previously approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@dgasmith dgasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that you can add labels to these now, looks good!

ZhuozhaoLi
ZhuozhaoLi reviewed Oct 8, 2019
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.md Outdated
A clear and concise description of what you expected to happen.

**Environment**
- OS: [e.g. iOS]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the example should be ubuntu, centos, MacOS, etc.

.github/ISSUE_TEMPLATE/feature_request.md Outdated
---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ex. -> E.g., ?

benclifford
benclifford previously approved these changes Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@benclifford benclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the phrasing can be tweaked a lot, but that is not a reason to not deploy these.

annawoodard
annawoodard previously approved these changes Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@annawoodard annawoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@yadudoc yadudoc dismissed stale reviews from annawoodard, benclifford, and dgasmith via 47de8d0 October 8, 2019 20:58
@benclifford benclifford merged commit d8ca3a5 into master Oct 8, 2019
@benclifford benclifford deleted the yadudoc-patch-1 branch October 8, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhuozhaoLi ZhuozhaoLi ZhuozhaoLi left review comments

@benclifford benclifford benclifford approved these changes

@annawoodard annawoodard annawoodard left review comments

@dgasmith dgasmith dgasmith left review comments

@danielskatz danielskatz Awaiting requested review from danielskatz

@kylechard kylechard Awaiting requested review from kylechard

Assignees
No one assigned
Labels
parslfest2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yadudoc @dgasmith @benclifford @annawoodard @ZhuozhaoLi