Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LookupAnything] Add integration with Extra Machine Config's multiple output items feature #1028

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

zombifier
Copy link
Contributor

@zombifier zombifier commented Aug 23, 2024

API Reference

For now basically add new recipes with the same ingredient list but new output items taken from EMC's API. It does mean the lookup can't distinguish between "the recipe can produce one of these items" and "the recipe will produce all of these items", but I don't think it's important to distinguish (and any solutions I can think of to distinguish them leads to combinatorics explosions if there are multiple possible outputs for each 'slots'). Plus, this is also how things currently work with building conversion recipes (e.g. Mill).

@zombifier zombifier marked this pull request as draft August 23, 2024 22:08
@zombifier zombifier marked this pull request as ready for review August 23, 2024 22:31
@zombifier
Copy link
Contributor Author

zombifier commented Oct 17, 2024

Seems like this will get spammy with the 'global byproduct' feature that adds a byproduct to every machine recipes. I'll need to rethink how the UI should work (maybe multiple items on one line), but a workaround for now is probably to exclude those, and only add the per-recipe byproduce.

@zombifier
Copy link
Contributor Author

zombifier commented Oct 27, 2024

To recap, here are the solutions I'm thinking for a recipe that takes A and returns B as a primary output, and C and D as secondary:

  1. (Existing) Show:
    • A => B
    • A => C
    • A => D
      Pros: simplest, most straightforward
      Cons: Doesn't communicate that C and D are byproduce from A to B, might bloat the screen for byproduce that applies to every recipe
  2. Show:
    • A => B only
    • Looking up C and D will show A => B
      Pros: Least clutter
      Cons: May not be clear
  3. Show:
    • A => B + C + D
      Pros: Clearest, best looking solution
      Cons: Extremely complicated, may lead to explosion of recipe counts if there are multiple items in the C and D slot

I'm still most happy with 1, but I'm interested to hear your thoughts.

@zombifier
Copy link
Contributor Author

zombifier commented Nov 24, 2024

Merged with latest develop, should work now (see screenshot for example from the new Wildflour Atelier Goods, which use this feature extensively. It can also be downloaded to test out).

2024-11-23T21:49:00,578091032-05:00

The recipe takes 2 milk and outputs all 4 of the items listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant