Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lookup Anything] Look up a body of water to see fishing data #1033

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

b3nk3lly
Copy link
Contributor

@b3nk3lly b3nk3lly commented Sep 13, 2024

Added FishingAreaSubject, which displays data about a body of water. It inherits from TileSubject. It uses FishSpawnRulesField.cs to display a list of fish and their spawning conditions. Closes #42.

The lookup shows all fish that can be caught in the body of water regardless of season, time, quests, etc. For fish that only spawn on certain tiles (e.g., Glacierfish at the island tip in the forest), the fish is only shown if the proper tile is looked up and the player is in the required position for it to spawn. Only the spawn conditions are shown; not spawn percentage chances or crab pot data.

I added a progression mode option to hide spawn info for fish the player hasn't caught. This also applies to lookups on fish.

There is currently a bug causing some spawn location names to appear as empty strings. I submitted a fix for that here: #1035

Other technical changes:

  • Added CheckboxList class, with inner classes Intro and Checkbox
  • Replaced instances of KeyValuePair<IFormattedText[], bool> with the new Checkbox class
  • CheckboxListField now supports multiple checkbox lists
  • CheckboxListField now supports drawing a sprite in the list intro
Screenshots

Mine level 100:

fishlookup-1
fishlookup-2

Mountains:

fishlookup-3

Beach:

fishlookup-4

Submarine:

fishlookup-5

Forest Pond:

fishlookup-6

Forest River:

fishlookup-7

Forest River, when standing in the required position for the Glacierfish to spawn:

fishlookup-8

New Progression Mode option:

image

Hidden spawn rules, when Progression Mode is enabled:

fishlookup-9

fishlookup-10

@b3nk3lly

This comment has been minimized.

@b3nk3lly b3nk3lly force-pushed the feature/fishing-tile-lookup branch from 9a610dc to 1c36ca2 Compare November 9, 2024 01:59
@b3nk3lly
Copy link
Contributor Author

b3nk3lly commented Nov 9, 2024

This is not finished yet - I still have some kinks to work out with the mineshaft floors. Any feedback is much appreciated !

Mine-related bugs are fixed, taking this out of WIP :)

@b3nk3lly b3nk3lly changed the title [WIP] [Lookup Anything] Look up a body of water to see fishing data [Lookup Anything] Look up a body of water to see fishing data Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lookup Anything] lookup water to see fishing data
1 participant