-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lookup Anything] Look up a body of water to see fishing data #1033
Open
b3nk3lly
wants to merge
20
commits into
Pathoschild:develop
Choose a base branch
from
b3nk3lly:feature/fishing-tile-lookup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Lookup Anything] Look up a body of water to see fishing data #1033
b3nk3lly
wants to merge
20
commits into
Pathoschild:develop
from
b3nk3lly:feature/fishing-tile-lookup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
b3nk3lly
force-pushed
the
feature/fishing-tile-lookup
branch
from
September 18, 2024 01:04
ea81547
to
25ffb30
Compare
…s can be looked up
b3nk3lly
force-pushed
the
feature/fishing-tile-lookup
branch
from
November 9, 2024 01:59
9a610dc
to
1c36ca2
Compare
…ecking whether to hide the list
…n location data. This fixes a bug where the location checkbox is unchecked for fish that spawn on any mine level like Ghost Fish or Cave Jelly.
Mine-related bugs are fixed, taking this out of WIP :) |
b3nk3lly
changed the title
[WIP] [Lookup Anything] Look up a body of water to see fishing data
[Lookup Anything] Look up a body of water to see fishing data
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
FishingAreaSubject
, which displays data about a body of water. It inherits fromTileSubject
. It usesFishSpawnRulesField.cs
to display a list of fish and their spawning conditions. Closes #42.The lookup shows all fish that can be caught in the body of water regardless of season, time, quests, etc. For fish that only spawn on certain tiles (e.g., Glacierfish at the island tip in the forest), the fish is only shown if the proper tile is looked up and the player is in the required position for it to spawn. Only the spawn conditions are shown; not spawn percentage chances or crab pot data.
I added a progression mode option to hide spawn info for fish the player hasn't caught. This also applies to lookups on fish.
There is currently a bug causing some spawn location names to appear as empty strings. I submitted a fix for that here: #1035Other technical changes:
CheckboxList
class, with inner classesIntro
andCheckbox
KeyValuePair<IFormattedText[], bool>
with the newCheckbox
classCheckboxListField
now supports multiple checkbox listsCheckboxListField
now supports drawing a sprite in the list introScreenshots
Mine level 100:
Mountains:
Beach:
Submarine:
Forest Pond:
Forest River:
Forest River, when standing in the required position for the Glacierfish to spawn:
New Progression Mode option:
Hidden spawn rules, when Progression Mode is enabled: