Skip to content

Commit

Permalink
feat: breaking changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Patisson4 committed Dec 21, 2022
1 parent a50fb9f commit 49eac76
Show file tree
Hide file tree
Showing 9 changed files with 58 additions and 31 deletions.
20 changes: 15 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,24 @@

## [0.1.1]

- Fix: jokes.json file now contains no jokes after initial plugin installation
- Feat: new command to request a random joke - no more expensive reboots to see fresh joke!
- Chore: API calls rate to get next joke is limited to 0.3 s
- Jokes.json file now contains no jokes after initial plugin installation
- New command to request a random joke - no more expensive reboots to see fresh joke!
- API calls rate to get next joke is limited to 0.3 s

## [0.1.2]

- Feat: add image icon to extension in marketplace
- Add image icon to extension in marketplace

## [0.1.3]

- Fix: remove jokes.json from initial download in order not to remove favourite jokes on every update
- Remove jokes.json from initial download in order not to remove favorite jokes on every update

## [0.1.4]

- Actual fix of accidental favorite jokes removal

## [1.1.4]

- Breaking changes: command `showJoke` renamed to `showFavorite`
- Now you can can call command `requestJoke` via presing button on status bar
- New image icon
24 changes: 16 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,38 @@
# AnecdoteExtension

Extension adds welcome anecdotes when starting VS Code
Extension adds welcome anecdotes when starting VS Code!

## Features

1) Read jokes from rzhunemogu.ru after launching VS Code and like your favorite
2) You can reread the jokes you like by clicking on the widget in the status bar or by calling the command
Read jokes from rzhunemogu.ru after launching VS Code and like your favorite.
You can reread the jokes you like by clicking on the widget in the status bar or by calling the command.

## Known Issues

Problems with updating page with favourite anecdotes while it webview is active or not in focused
Problems with updating page with favorite anecdotes while it webview is active or not in focused.

## Release Notes

### 0.0.1

Initial release of extension
Initial release of extension.

### 0.1.1

Minor features, fixes and improvements
Minor features, fixes and improvements.

### 0.1.2

Add image icon to extension in marketplace
Add image icon to extension in marketplace.

### 0.1.3

- Hotfix
Hotfix!

### 0.1.4

Actual Hotfix ¯\\\_(ツ)\_

### 1.2.4

Breaking changes and new features
Binary file removed icon.jpg
Binary file not shown.
Binary file added icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 10 additions & 6 deletions out/extension.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion out/extension.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"name": "anecdotextension",
"displayName": "Anecdote Extension",
"description": "Simple VS Code extension to welcome you with an anecdote after launch",
"version": "0.1.4",
"icon": "icon.jpg",
"version": "1.1.4",
"icon": "icon.png",
"engines": {
"vscode": "^1.73.0"
},
Expand All @@ -23,7 +23,7 @@
"contributes": {
"commands": [
{
"command": "anecdotextension.showStats",
"command": "anecdotextension.showFavorite",
"title": "Show anecdote statistics",
"category": "Anecdotes"
},
Expand Down
17 changes: 11 additions & 6 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export async function activate(context: vscode.ExtensionContext) {
context.subscriptions.push(vscode.commands.registerCommand('anecdotextension.requestJoke', () => showJoke(context)));

context.subscriptions.push(
vscode.commands.registerCommand('anecdotextension.showStats', () => {
vscode.commands.registerCommand('anecdotextension.showFavorite', () => {
const columnToShowIn = vscode.window.activeTextEditor
? vscode.window.activeTextEditor.viewColumn
: undefined;
Expand Down Expand Up @@ -47,10 +47,15 @@ export async function activate(context: vscode.ExtensionContext) {
})
);

const statusBarItem = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Right);
statusBarItem.text = 'Favourite Jokes';
statusBarItem.command = 'anecdotextension.showStats';
statusBarItem.show();
const statusBarItem1 = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Right);
statusBarItem1.text = 'Random Joke';
statusBarItem1.command = 'anecdotextension.requestJoke';
statusBarItem1.show();

const statusBarItem2 = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Right);
statusBarItem2.text = 'Favorite Jokes';
statusBarItem2.command = 'anecdotextension.showFavorite';
statusBarItem2.show();
}

export function deactivate() { }
Expand Down Expand Up @@ -124,7 +129,7 @@ function getWebviewContent(content: string) {
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Favourite Jokes</title>
<title>Favorite Jokes</title>
</head>
<body>
${content}
Expand Down

0 comments on commit 49eac76

Please sign in to comment.