Disabled Keyguard service restart on kill

PaulAnnekov · Oct 15, 2013 · 2f183f6 · 2f183f6
1 parent 206212a
commit 2f183f6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/NFC Unlocker/gen/.gitignore b/NFC Unlocker/gen/.gitignore
@@ -0,0 +1 @@
+/com
diff --git a/NFC Unlocker/res/values/strings_settings.xml b/NFC Unlocker/res/values/strings_settings.xml
@@ -15,7 +15,7 @@
     <string-array name="pref_unlock_method_entries">
 	   <item>Flag</item>
 	   <item>Input</item>
-	   <item>KeyguardLock</item>
+	   <item>KeyguardLock (unstable)</item>
 	</string-array>
 
 	<string-array name="pref_unlock_method_values">

diff --git a/NFC Unlocker/src/com/steelrat/nfcunlocker/unlockmethods/KeyguardUnlock.java b/NFC Unlocker/src/com/steelrat/nfcunlocker/unlockmethods/KeyguardUnlock.java
@@ -88,7 +88,6 @@ public static class KeyguardService extends Service {
 
 	    @Override
 		public int onStartCommand(Intent intent, int flags, int startId) {
-	    	// TODO: intent may be null if service was killed by OS and re-created.
 	    	String action = intent.getAction();
 
 	    	// Create new broadcast receiver for screen off action.
@@ -101,15 +100,18 @@ public int onStartCommand(Intent intent, int flags, int startId) {
 				stopSelf();
 			}
 
-			return super.onStartCommand(intent, flags, startId);
+			// Don't restart service after kill. Keyguard will be re-enabled in
+			// onDestroy automatically.
+			return START_NOT_STICKY;
 		}
 
 	    @Override
 	    public void onDestroy() {
 	    	super.onDestroy();
 
+	    	restoreKeygurad();
+
 	    	if (mReceiver != null) {
-	    		restoreKeygurad();
 	    		unregisterReceiver(mReceiver);
 	    	}
 	    }