[Feature] 이메일 인증번호 발송 API 구현 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hojeong2747
approved these changes
Oct 28, 2023
| @@ -7,6 +7,8 @@ | |||
| @RequiredArgsConstructor | |||
| public enum ErrorCode { | |||
|
|
|||
| EMAIL_SEND_ERROR("S1", "이메일 인증 코드 전송을 실패했습니다."), | |||
There was a problem hiding this comment.
Sign-up이라 S로 했는데! 다른 걸로 할까요??
There was a problem hiding this comment.
아항
아뇨 회원가입 때 쓰이는 거니까 좋네요!_!
There was a problem hiding this comment.
이후 같의 논의한 건 기록입니당
- 에러코드가 여러 도메인에 종속될 수 있기 때문에 에러코드명을 도메인을 따라갈지, 에러 내용을 따라갈지 고민 -> 후자로 결정 (ex. 인증 관련이면 "A1")
- Validation 처리에서 발생하는 MethodArgumentNotValidException은 "V1"
hojeong2747
approved these changes
Oct 28, 2023
| @@ -10,6 +10,7 @@ public enum ErrorCode { | |||
| ALREADY_EXIST_EMAIL("A1", "이미 존재하는 이메일입니다."), | |||
| ALREADY_EXIST_NICKNAME("A2", "이미 존재하는 사용자 닉네임입니다."), | |||
| ALREADY_LOGOUT_MEMBER("A3", "이미 로그아웃한 회원입니다"), | |||
| EMAIL_SEND_ERROR("A4", "이메일 인증 코드 전송을 실패했습니다."), | |||
There was a problem hiding this comment.
Auth 관련 묶어서 사용하기로 결정했군! 좋습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #16
📝 작업 내용
이메일 인증번호 발송 API 구현
💬 리뷰 요구 사항
mail.html을 만들었는데 다음과 같이 인증 번호가 전송됩니다! 조금 더 예쁘게 바꾸고 싶긴 한데!
css 추가하면 되려나 안드로이드 호정님?!