[Feature] 이동봉사자, 이동봉사 중개 자체 회원가입 API 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hojeong2747
approved these changes
Oct 29, 2023
| Intermediary intermediary = IntermediarySignUpRequest.toEntity(request, authImage); | ||
| intermediary.passwordEncode(passwordEncoder); | ||
| intermediaryRepository.save(intermediary); | ||
| } |
There was a problem hiding this comment.
request, file 한 번에 받는 형식 잘 구현한 것 같습니다 👍
| throw new BadRequestException(ALREADY_EXIST_EMAIL); | ||
| } | ||
| try{ | ||
| // 메일전송에 필요한 정보 설정 | ||
| MimeMessage emailForm = createEmailForm(emailRequest.email()); | ||
| MimeMessage emailForm = createEmailForm(request.email()); |
There was a problem hiding this comment.
보니까 request dto 파라미터명을 request로 전부 수정했네요.
장단점이 있지만 저는 이렇게 쓰는 거 좋아합니다 ㅎ.ㅎ
There was a problem hiding this comment.
테스트 코드를 작성하다가 들었던 생각인데! dto에 넣을 request 이름을 개별 메소드마다 다르게 지정할 때 변경해야 하는 번거로움이 있더라고요! request 앞에는 사용할 Dto record의 이름이 들어가니까 괜찮다고 판단해서 바꿨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #21
📝 작업 내용
💬 리뷰 요구 사항
이동봉사 중개 회원가입 시 Dto와 파일(인증용 사진)을 함께 받기 위해 multipart/form-data로 전송하는 방식을 적용했습니다!
파일을 다루는 부분에 있어서 수정할 코드가 있다면 말해주세요!