-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: BCH using chronik #843
Conversation
fix: multinetwork chronik client & admin view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
57078b4
to
14d7f8b
Compare
Also we do already have a task for click-to-copy not working right on BCH: PayButton/paybutton#417 |
Let's address the BCH success trigger in PayButton/paybutton#403 instead. |
32f237c
to
7387f6c
Compare
952c1c1
to
e89864c
Compare
Alright
I don't follow.
You have to remove it from your
Could you confirm you are still getting those now? |
It's a client-side issue so let's just make sure it's working in PayButton/paybutton#403. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job on this! Works great.
@chedieck Before we merge this, what could we do for tests as I don't see any thing new added for this one. |
Just added some tests, making sure chronik works for both ecash and bitcoincash. |
Related to #412
Description
Sets up Chronik for BCH.
Essentially meaning BCH network should now work normally, just as XEC does.
Test plan
Change config
Config should change now, check
config/example-config.json
. You can remove obsolete variables likegrpcClient...URL
,chronikClientURL
and add the newnetworkBlockchainURLs
variable:...besides modifying
networkBlockchainClients
so that it says:Also, remove the property
networksUnderMaintenance
so it won't inactivate BCH.Now, after rebooting the containers, bitcoincash should sync and work normally.
Remarks
When working on this issue, I found some issues with Bitcoin Cash in the client.
I'll create a PR in the client to fix those.