fix: price upsert error #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potential options for speeding up the syncing process? We're currently doing 200 tx/s. Do we run into issues above this? |
It's the Chronik's limit of how many txs to fetch per call. Then it takes a while between each subsequent call because we have to connect all these txs to addresses and prices we have in the DB, but I can have a look in another PR into making each one of these iterations take less time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #905
Description
When adding a big address (like ecash:prfhcnyqnl5cgrnmlfmms675w93ld7mvvqd0y8lz07), if the syncing process encountered some missing prices, this would lead to the error mentioned on #905.
This PR fixes this error, by uncoupling the process of filling up the missing prices and connecting it to the transaction.
Test plan
On master, after restarting the containers, try adding the aforementioned address to a button. After adding 200 txs around 10 times, it should result on the error happening multiple times.
Then restart the containers again on this branch, it should work fine.