feat: sideshift integration #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
requested changes
Jul 1, 2024
Klakurka
requested changes
Jul 2, 2024
addressed. |
Klakurka
approved these changes
Jul 2, 2024
|
This is one of those situations where it would have been good to put this behind a "feature flag" but I'm also ok just merging it as-is. If we had a bit more going on where we'd want to deploy some other feature/fix before this went live, we'd definitely want that flag there to be able to switch it on once it's actually ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #187
Description
Adds logic to select coins using SideShift's API, displays their amount and the rate of conversion.
This PR adds the logic for selecting the amount & currency to pay with, but it doesn't yet implement the payment itself.
E.g, by selecting BTC and clicking "Pay with BTC", nothing will happen aside from a console.log of "WIP".
It's also important to notice that I didn't work in the design of the components, only their functionality. This PR lays ground for a frontend work to be done, with the goal of making the new stuff more intuitive and agreeable for the eyes.
Finally, it is also important to notice that this PR is off of a proxy branch, meaning approving and merging it won't commit anything to master (since it's incomplete). Nonetheless, it should be reviewed as if the changes here proposed are good enough (in what they propose to address) to eventually go to master (when all the changes are complete).
Test plan
For editable and non-editable paybuttons, there should be a "Don't have any XEC?" text which upon clicking will allow the user to select an alternative cryptocurrency to pay with.