Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: realocate, rename, uncommit config #434

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

chedieck
Copy link
Collaborator

Description

Realocates the config file to the root dir, so it's not hidden in a place that has to be memorized (it was in react/lib before).
Also changes its name from config.json to paybutton-config.json and leaves it gitignored. An additional file called example-config.json was added too, also to the root directory.

Test plan

Just run yarn dev, the example config should be copied to the new expected location ./paybutton-config.json and then the software should run as always.

@Klakurka Klakurka self-requested a review November 13, 2024 13:11
Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work but there's a test failure.

@Klakurka Klakurka merged commit b774095 into master Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants