Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text empty nbsp #441

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: text empty nbsp #441

merged 2 commits into from
Dec 20, 2024

Conversation

lissavxo
Copy link
Collaborator

Related to #428

Description

Added logic to render <div>&nbsp;</div> when text is empty string

Test plan

Run the project with yarn dev and test the button with prop text=""

@Klakurka Klakurka self-requested a review December 12, 2024 20:31
Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still getting this on the button generator dev page
image

@lissavxo lissavxo requested a review from Klakurka December 19, 2024 20:33
@Klakurka Klakurka requested a review from chedieck December 19, 2024 23:02
@Klakurka Klakurka merged commit 597a35c into master Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants