[PAN-3023] Add command line option for target gas limit #1917
Conversation
|
|
| @Option( | ||
| names = {"--target-gas-limit"}, | ||
| description = | ||
| "Sets target gas limit per block. If set each blocks gas limit will approach this setting over time if the current gas limit is different.") |
There was a problem hiding this comment.
@MadelineMurray for help description text review
NicolasMassart
requested review from
mbaxter,
AbdelStark,
RatanRSur,
shemnon and
MadelineMurray
.../src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/node/ThreadPantheonNodeRunner.java
Outdated
Show resolved
Hide resolved
| @@ -84,6 +85,7 @@ | |||
| protected Clock clock; | |||
| protected KeyPair nodeKeys; | |||
| protected boolean isRevertReasonEnabled; | |||
| protected Function<Long, Long> gasLimitCalculator; | |||
There was a problem hiding this comment.
Instead of a type Function field I think we should consider a special case GasLimitCalculator functional interface. It will make it more obvious what the type does. Here and the other places in the code we us it (the compiler errors should tell you where, one advantage of a strongly typed language).
It will also give a home to the eth spec standard 'no more than 1/1024th per block` adjustment code.
There was a problem hiding this comment.
The standalone replacement for GasLimitCalculator is optional, but we do need to find a better home for the calculator in PantheonCommand
There was a problem hiding this comment.
The thing that maybe argues in favor of a standalone GasLimitCalculator is what would be needed to have PAN-3031 (Add JSON-RPC method to set target block gas limit) later on. I'll look at some as well..
pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
Outdated
Show resolved
Hide resolved
|
Great feedback, I'll start working through this on Thursday when back at my computer. |
# Conflicts: # acceptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/node/ThreadPantheonNodeRunner.java # pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java # pantheon/src/main/java/tech/pegasys/pantheon/controller/PantheonControllerBuilder.java # pantheon/src/test/java/tech/pegasys/pantheon/cli/CommandTestAbstract.java # pantheon/src/test/java/tech/pegasys/pantheon/cli/PantheonCommandTest.java # pantheon/src/test/resources/everything_config.toml
PR description
Adds the --target-gas-limit command line option.
Gradually changes the block gas limit towards this target when option enabled.
Fixed Issue(s)
https://pegasys1.atlassian.net/browse/PAN-3023