Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_nifti_info ImageOrientation 'None' in tuple fix #428

Merged
merged 1 commit into from
Feb 10, 2025
Merged

add_nifti_info ImageOrientation 'None' in tuple fix #428

merged 1 commit into from
Feb 10, 2025

Conversation

ashleychari
Copy link
Collaborator

Changes proposed in this pull request

  • Add line which casts all orientations in tuple to be a string before they are joined together. This catches the None in the tuple before it is joined as a string.
cubids_add_nifti_info_error

Documentation that should be reviewed

  • add_nifti_info function contains the fix and should be reviewed

mattcieslak
mattcieslak approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattcieslak mattcieslak merged commit f144803 into main Feb 10, 2025
7 of 9 checks passed
@mattcieslak mattcieslak deleted the add_nifti_img_orientation branch February 10, 2025 16:10
@tsalo tsalo added the bug Something isn't working label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcieslak mattcieslak mattcieslak approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleychari @mattcieslak @tsalo