Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v0.40.0 Doc branch #1034

Merged
merged 20 commits into from
Jan 13, 2025
Merged

Create v0.40.0 Doc branch #1034

merged 20 commits into from
Jan 13, 2025

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Jan 9, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD added the urgent Mark a pull request as high priority label Jan 9, 2025
@multiphaseCFD multiphaseCFD requested review from maliasadi and a team January 9, 2025 19:30
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @multiphaseCFD

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.36%. Comparing base (c55e082) to head (277db3c).
Report is 1 commits behind head on v0.40.0_rc.

❗ There is a different number of reports uploaded between BASE (c55e082) and HEAD (277db3c). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (c55e082) HEAD (277db3c)
15 11
Additional details and impacted files
@@               Coverage Diff               @@
##           v0.40.0_rc    #1034       +/-   ##
===============================================
- Coverage       95.15%   27.36%   -67.79%     
===============================================
  Files             112       29       -83     
  Lines           16990     2646    -14344     
===============================================
- Hits            16166      724    -15442     
- Misses            824     1922     +1098     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @multiphaseCFD

josephleekl and others added 3 commits January 10, 2025 13:29
### Before submitting

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

[sc-81816]

---------

Co-authored-by: Luis Alfredo Nuñez Meneses <[email protected]>
@multiphaseCFD multiphaseCFD marked this pull request as ready for review January 10, 2025 18:31
@maliasadi maliasadi marked this pull request as draft January 10, 2025 19:21
@josh146 josh146 requested a review from DSGuala January 10, 2025 19:37
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left some minor comments 👍 🚀

.github/CHANGELOG.md Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once previous comments are addressed 👍

@multiphaseCFD multiphaseCFD marked this pull request as ready for review January 13, 2025 17:54
@multiphaseCFD multiphaseCFD merged commit f115714 into v0.40.0_rc Jan 13, 2025
111 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants