-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dyn-alloc-lk] Lightning Kokkos support dynamic qubit allocation #1049
base: dyn-alloc
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dyn-alloc #1049 +/- ##
=============================================
+ Coverage 94.86% 95.27% +0.41%
=============================================
Files 178 112 -66
Lines 27559 17054 -10505
=============================================
- Hits 26145 16249 -9896
+ Misses 1414 805 -609 ☔ View full report in Codecov by Sentry. |
Your CI, Testing without binary-GPU, is currently failing. Could you please check that? |
Thanks, I've fixed it now. I've removed the abstractmethod from the baseAPI class, because only LQ/LK/LG use it, but not LT. This should fix the issues! |
@@ -243,6 +243,9 @@ jobs: | |||
OMP_PROC_BIND: false | |||
run: | | |||
DEVICENAME=`echo ${{ matrix.pl_backend }} | sed "s/_/./g"` | |||
# Temporarily rename source files here to ensure pytest collect source coverage from wheel package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IGNORE CHANGES TO THIS FILE
This is to get code coverage for lkcpu, which is from this PR https://github.com/PennyLaneAI/pennylane-lightning/pull/1053/files . This update is temporary
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This PR adds support for dynamic allocation for LK, and merges into [dyn-alloc-base], which contains the update for dynamic allocation for lightning.qubit.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-82704]