Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dyn-alloc-lk] Lightning Kokkos support dynamic qubit allocation #1049

Open
wants to merge 37 commits into
base: dyn-alloc
Choose a base branch
from

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 24, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
This PR adds support for dynamic allocation for LK, and merges into [dyn-alloc-base], which contains the update for dynamic allocation for lightning.qubit.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-82704]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@josephleekl josephleekl changed the title Lightning Kokkos support dynamic qubit allocation [dyn-alloc-lk] Lightning Kokkos support dynamic qubit allocation Jan 24, 2025
@josephleekl josephleekl marked this pull request as ready for review January 24, 2025 19:09
@josephleekl josephleekl added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.27%. Comparing base (d3fcf02) to head (6608caf).

Files with missing lines Patch % Lines
...ane_lightning/lightning_kokkos/lightning_kokkos.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           dyn-alloc    #1049      +/-   ##
=============================================
+ Coverage      94.86%   95.27%   +0.41%     
=============================================
  Files            178      112      -66     
  Lines          27559    17054   -10505     
=============================================
- Hits           26145    16249    -9896     
+ Misses          1414      805     -609     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl removed the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 27, 2025
@AmintorDusko
Copy link
Contributor

Your CI, Testing without binary-GPU, is currently failing. Could you please check that?

@josephleekl
Copy link
Contributor Author

josephleekl commented Jan 28, 2025

Your CI, Testing without binary-GPU, is currently failing. Could you please check that?

Thanks, I've fixed it now. I've removed the abstractmethod from the baseAPI class, because only LQ/LK/LG use it, but not LT. This should fix the issues!

@josephleekl josephleekl marked this pull request as draft January 31, 2025 19:43
@@ -243,6 +243,9 @@ jobs:
OMP_PROC_BIND: false
run: |
DEVICENAME=`echo ${{ matrix.pl_backend }} | sed "s/_/./g"`
# Temporarily rename source files here to ensure pytest collect source coverage from wheel package
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IGNORE CHANGES TO THIS FILE

This is to get code coverage for lkcpu, which is from this PR https://github.com/PennyLaneAI/pennylane-lightning/pull/1053/files . This update is temporary

@josephleekl josephleekl added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 31, 2025
@josephleekl josephleekl marked this pull request as ready for review January 31, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-gpu-runner Enable usage of GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants