-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dyn-alloc-lg] Lightning GPU dynamically allocate qubit memory #1050
base: dyn-alloc-lk
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dyn-alloc-lk #1050 +/- ##
================================================
- Coverage 95.27% 92.61% -2.67%
================================================
Files 112 112
Lines 17054 17067 +13
================================================
- Hits 16249 15806 -443
- Misses 805 1261 +456 ☔ View full report in Codecov by Sentry. |
@josephleekl, could you please check the formatting? |
Will do, thanks! (Taking care of 3 chained PRs is chaotic...) |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This PR adds support for dynamic allocation for LG, and merges into [dyn-alloc-lk], which contains the update for dynamic allocation for lightning.kokkos.
LGPU + MPI is not supported right now.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-82704]