Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dyn-alloc-lg] Lightning GPU dynamically allocate qubit memory #1050

Open
wants to merge 36 commits into
base: dyn-alloc-lk
Choose a base branch
from

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 24, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
This PR adds support for dynamic allocation for LG, and merges into [dyn-alloc-lk], which contains the update for dynamic allocation for lightning.kokkos.

LGPU + MPI is not supported right now.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-82704]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 92.61%. Comparing base (6608caf) to head (fc1e284).

Files with missing lines Patch % Lines
pennylane_lightning/lightning_gpu/lightning_gpu.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           dyn-alloc-lk    #1050      +/-   ##
================================================
- Coverage         95.27%   92.61%   -2.67%     
================================================
  Files               112      112              
  Lines             17054    17067      +13     
================================================
- Hits              16249    15806     -443     
- Misses              805     1261     +456     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Jan 27, 2025
@josephleekl josephleekl marked this pull request as ready for review January 27, 2025 15:59
@josephleekl josephleekl requested review from maliasadi, multiphaseCFD and LuisAlfredoNu and removed request for maliasadi and multiphaseCFD January 28, 2025 14:29
@AmintorDusko
Copy link
Contributor

@josephleekl, could you please check the formatting?

@josephleekl
Copy link
Contributor Author

josephleekl commented Jan 28, 2025

@josephleekl, could you please check the formatting?

Will do, thanks! (Taking care of 3 chained PRs is chaotic...)

@josephleekl josephleekl marked this pull request as draft January 31, 2025 19:43
@josephleekl josephleekl marked this pull request as ready for review January 31, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-gpu-runner Enable usage of GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants