-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isort check to pre commit hook #1052
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1052 +/- ##
===========================================
- Coverage 94.36% 33.25% -61.12%
===========================================
Files 233 29 -204
Lines 39236 2607 -36629
===========================================
- Hits 37026 867 -36159
+ Misses 2210 1740 -470 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @albi3ro !
Context:
When making a recent PR, I messed up isort because it wasn't being checked by the precommit hook.
Description of the Change:
Adds
isort
to the precommit hook.Benefits:
Fewer commits that are only fixing style issues.
Possible Drawbacks:
Related GitHub Issues: