Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort check to pre commit hook #1052

Merged
merged 11 commits into from
Jan 29, 2025
Merged

Add isort check to pre commit hook #1052

merged 11 commits into from
Jan 29, 2025

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Jan 27, 2025

Context:

When making a recent PR, I messed up isort because it wasn't being checked by the precommit hook.

Description of the Change:

Adds isort to the precommit hook.

Benefits:

Fewer commits that are only fixing style issues.

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.25%. Comparing base (f4b244f) to head (9e2d2c0).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f4b244f) and HEAD (9e2d2c0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f4b244f) HEAD (9e2d2c0)
7 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1052       +/-   ##
===========================================
- Coverage   94.36%   33.25%   -61.12%     
===========================================
  Files         233       29      -204     
  Lines       39236     2607    -36629     
===========================================
- Hits        37026      867    -36159     
+ Misses       2210     1740      -470     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@albi3ro albi3ro requested a review from josephleekl January 27, 2025 22:21
Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @albi3ro !

@albi3ro albi3ro merged commit 2b777f7 into master Jan 29, 2025
69 of 70 checks passed
@albi3ro albi3ro deleted the precommit-isort branch January 29, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants