-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code coverage for LQ/LK CPU Python #1053
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1053 +/- ##
===========================================
- Coverage 97.86% 62.60% -35.26%
===========================================
Files 233 29 -204
Lines 39537 2607 -36930
===========================================
- Hits 38691 1632 -37059
- Misses 846 975 +129 ☔ View full report in Codecov by Sentry. |
@josephleekl, many CIs are failing at the moment. Let me know when fixed. 🙂 |
Thanks @AmintorDusko , the failed CIs are all related to ARM Wheel builds, which is a separate unrelated issue. We're seeing those on master branch too (e.g.); @maliasadi mentioned he'll investigate that issue later on. update: the issue is fixed with this PR |
CIs are green again @AmintorDusko :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @josephleekl! Nice increase in Coverage! Cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josephleekl! Nice work 🥳
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Currently Lightning Qubit and Lightning Kokkos (CPU) Python coverage is not collected, leading to low coverage in LQ and LK as seen here (Previously LK contains coverage from GPU tests, but not CPU tests).
Description of the Change:
In the lkcpu and lqcpu python CI:
.coveragerc
so they can be combined properlyBenefits:
We will have coverage for LQ/LK python again, as seen here.
Possible Drawbacks:
Related GitHub Issues:
[sc-83296]