Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lightning-latest-rc kokkos failure #100

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix lightning-latest-rc kokkos failure #100

merged 1 commit into from
Jan 6, 2025

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 6, 2025 •
edited
Loading

This PR fixes the issue that Lightning Kokkos was not installed due to missing a step to update the pyproject toml, resulting in failed test.

[sc-81613]

@josephleekl josephleekl marked this pull request as ready for review January 6, 2025 17:53
maliasadi
maliasadi approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

multiphaseCFD
multiphaseCFD approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thank you @josephleekl

@maliasadi maliasadi merged commit acdda33 into master Jan 6, 2025
33 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multiphaseCFD multiphaseCFD multiphaseCFD approved these changes

@maliasadi maliasadi maliasadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephleekl @maliasadi @multiphaseCFD