raise PL deprecations as errors #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2023
albi3ro
approved these changes
Nov 10, 2023
This was referenced Nov 10, 2023
|
Is this what is causing stable/stable to fail for the plugins? E.g. for braket to fail? |
|
yes. oh boy. i'll fix it |
timmysilv
added a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Nov 13, 2023
**Context:** This warning was added eons ago (#2634), but it pre-dates our deprecation management page so it slipped through the cracks. **Description of the Change:** Remove the support for passing `control_values` as a string to `qml.ctrl` **Benefits:** Deprecation cycle is now complete! **Possible Drawbacks:** It wasn't on our deprecations page and was therefore never formally scheduled for removal. But you know.. it's been almost 10 releases. NOTE: I want to see PennyLaneAI/plugin-test-matrix#57 merged and get a look at the matrix before we merge this into master. Too many things breaking at once 😓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title says.
pytest --helpshows that it processes-Woptions before processing anyfilterwarningsconfig options, so this should do it.