Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: DICOM To NRRD Module Implementation #30

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alex-myers
Copy link

The DICOM To NRRD module provides batch processing for converting DICOM files into NRRD files and outputs the files into a DICOM standard conforming folder hierarchy of Patient/Study/Series.

Reference discussion forum:
https://discourse.slicer.org/t/possible-new-slicer-extension-dicomtonrrdbatchprocessing/33284

Reference pull request:
Hi please reference Slicer/Slicer#7502

The recommended changes from the pull request have been added to this fork.

alex-myers and others added 7 commits June 26, 2024 15:41
    The DICOM To NRRD module provides batch processing for converting
    DICOM files into NRRD files and outputs the files into a
    DICOM standard conforming folder hierarchy of Patient/Study/Series.

    I updated DICOMToNRRD.py with the changes recommended by Andras Lasso
    from pull request: Slicer/Slicer#7502
    Thank you for your valuable feedback.
Added the DICOMtoNRRD directory to CMakeLists and updated the README
with the new sandbox module
Finished the current test case and logged the result
Reducing the logo image size to 128x128 in the README.md
Removed logo since resizing does not work
I fixed typos caught by the build process, and tested
the DICOMToNRRD module with the Multiple Myeloma Collection.
@alex-myers
Copy link
Author

alex-myers commented Dec 9, 2024

This is for Slicer issue 7500: Slicer/Slicer#7500. If this module receives a lot of use, in the future I'll take advantage of parallel processing: https://github.com/pieper/SlicerParallelProcessing.

@lassoan, I know you're hoping this "module becomes very robust and capable" - Andras Lasso - https://discourse.slicer.org/t/possible-new-slicer-extension-dicomtonrrdbatchprocessing/33284/4

I documented ten different isolated tests cases with the same code. Let me know what you think it'll take to become robust and capable.

@alex-myers
Copy link
Author

Hi @jcfr

I want to bring you in on the discussion. Your extension https://github.com/hina-shah/SlicerBatchAnonymize has potentially duplicate functionality for converting DICOM to NRRD. I installed your extension and ran the Dicom To Nrrd Conversion. The functionality is deprecated as I received this error:

"Error: the output file type is not supported currently
Deprecated feature no longer supported: --fMRIOutput"

I want to verify that this module makes sense as a standalone DicomToNRRD as Diffusion-weighted DICOM Import extracts diffusion weighting directions, v-values, and measurement frames. DICOMToNRRD takes an input DICOM directory and outputs NRRD files with an optional DICOM information JSON file in a Name/Study/Series hierarchy that conforms to DICOM standards.

Let me know your thoughts and whether you think it makes sense for me to combine the functionality into Diffusion-weighted DICOM Import or keep this as a simple standalone module at this time.

Thanks,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant