change extra_data with atomic operations to reduce concurrent problems #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrDlouhy
force-pushed
the
pr/atomic_changes
branch
2 times, most recently
from
10ee32d to
93fb86d
Compare
PetrDlouhy
force-pushed
the
pr/atomic_changes
branch
from
93fb86d to
6182fad
Compare
radekholy24
reviewed
Nov 22, 2024
| @@ -43,16 +43,20 @@ | |||
|
|
|||
|
|
|||
| def add_extra_data(payment, new_extra_data): | |||
| payment.refresh_from_db() | |||
There was a problem hiding this comment.
Wouldn't this be better?
Suggested change
| payment.refresh_from_db() | |
| payment.refresh_from_db(fields=["extra_data"]) |
Just to make it more future-proof...
radekholy24
reviewed
Nov 22, 2024
|
|
||
|
|
||
| def add_new_status(payment, new_status): | ||
| payment.refresh_from_db() |
There was a problem hiding this comment.
Wouldn't this be better?
Suggested change
| payment.refresh_from_db() | |
| payment.refresh_from_db(fields=["extra_data"]) |
Just to make it more future-proof...
radekholy24
reviewed
Nov 22, 2024
Comment on lines
+68
to
+70
| payment._change_reason = 'PayU Payments: add_new_status' # For django-simple-history | ||
| payment.save(update_fields=["extra_data"]) | ||
| payment._change_reason = None |
There was a problem hiding this comment.
Also this (as well as in all the other cases) may be a bit safer:
Suggested change
| payment._change_reason = 'PayU Payments: add_new_status' # For django-simple-history | |
| payment.save(update_fields=["extra_data"]) | |
| payment._change_reason = None | |
| payment._change_reason, payment_change_reason_original = 'PayU Payments: add_new_status', payment._change_reason # For django-simple-history | |
| payment.save(update_fields=["extra_data"]) | |
| payment._change_reason = payment_change_reason_original |
Or maybe
Suggested change
| payment._change_reason = 'PayU Payments: add_new_status' # For django-simple-history | |
| payment.save(update_fields=["extra_data"]) | |
| payment._change_reason = None | |
| payment._change_reason = (payment._change_reason or '') + 'PayU Payments: add_new_status' # For django-simple-history | |
| payment.save(update_fields=["extra_data"]) | |
| payment._change_reason = None |
🤔
But I may be overengineering this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pokus o opravu https://github.com/BlenderKit/BlenderKit-server/issues/951