Parse the code section #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgil-serbanuta
force-pushed
the
parse-functions-refactor
branch
from
1d75164 to
fced21b
Compare
sskeirik
reviewed
Jan 25, 2025
| @@ -20,10 +24,11 @@ module BINARY-PARSER-INT [private] | |||
| rule bit8IsSet(I:Int) => I &Int 128 =/=Int 0 | |||
|
|
|||
| syntax Int ::= clearBit8(Int) [function, total] | |||
| rule clearBit8(I:Int) => I ^Int (I &Int 128) | |||
| rule clearBit8(I:Int) => I -Int 128 requires 128 <=Int 128 | |||
There was a problem hiding this comment.
Looks like a typo --- I'm assuming you want this:
Suggested change
| rule clearBit8(I:Int) => I -Int 128 requires 128 <=Int 128 | |
| rule clearBit8(I:Int) => I -Int 128 requires 128 <=Int I |
| module BINARY-PARSER-FUNC-SYNTAX | ||
| imports BINARY-PARSER-BASE-SYNTAX | ||
|
|
||
| syntax DefnResult ::= parseDefnFunc(BytesWithIndex) [function, total] |
There was a problem hiding this comment.
I think that this function defined here is not used anywhere; probably this code was used somewhere but then a refactor happened which made it unnecessary.
Comment on lines
+68
to
+70
| syntax Int ::= buildLeb128UInt(Ints) [function, total] | ||
| rule buildLeb128UInt(.Ints) => 0 | ||
| rule buildLeb128UInt(Value:Int L:Ints) => Value +Int 128 *Int buildLeb128UInt(L) |
There was a problem hiding this comment.
Might be redundant with the definition on lines 57-59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61