Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix python lib install path (#207)" #236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sea-bass
Copy link
Collaborator

@sea-bass sea-bass commented Jan 11, 2025

This reverts commit 4e92cc4.

Turns out I took #207 in good faith, but it does cause problems.

Without that PR, this is what a custom module named admittance_params.py installs into. This is correct:

image

With that PR, it goes to the wrong folder one level up:

image

@sea-bass
Copy link
Collaborator Author

@agonzat FYI, I think this change needs to be reverted. If you have any information on the motivation behind your original PR (#207), please let us know!

Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, because it seems there were less issues before the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants