new flags, fix sqlite and bootloop on a11

changelog.md

@@ -1,3 +1,9 @@
+**2022-03-03 (22030300)**
+- Fixed [insert_gms_features()](https://github.com/Pixel-Props/pixel.features/blob/main/addon/SQLite3/install.sh) where variables were not defined which caused the service to not install flags properly.
+- Added more flags to the [service.sh](https://github.com/Pixel-Props/pixel.features/blob/main/system/product/etc/sysconfig/service.sh)
+- SDK checks installer. [privapp-permissions-google-p.xml](https://github.com/Pixel-Props/pixel.features/blob/main/system/product/etc/permissions/privapp-permissions-google-p.xml) will be removed from the module (Causing [Bootloop on A11](https://github.com/Pixel-Props/pixel.features/issues/3#issuecomment-1057879710)).
+- The service.sh is still not working. I am opening an issue on the Magisk repo.
+
 **2022-02-28 (22022801-22022802)**
 - Enabling new Google Dialer pad on sqlite3 GMS
 - Disabled uninstaller as it is too destructive for now
@@ -10,7 +16,7 @@
 - SDK checks for NgaResources, DevicePersonalization and PixelWallpapers2021
 - Previously the script was not installing packages, Now it has a proper [install_package()](https://github.com/Pixel-Props/pixel.features/blob/main/addon/Utils/install.sh).
 - The script now automatically warns the user if there is a newer version of the script.
-- Patching device_config flags and system prefs at [service.payload.sh](https://github.com/Pixel-Props/pixel.features/blob/main/system/product/etc/sysconfig/service.payload.sh)
+- Patching device_config flags and system prefs at [service.sh](https://github.com/Pixel-Props/pixel.features/blob/main/system/product/etc/sysconfig/service.sh)
 - Checks for memory availability before using [GoogleCamera_6gb_or_more_ram.xml](https://github.com/Pixel-Props/pixel.features/blob/main/system/product/etc/sysconfig/GoogleCamera_6gb_or_more_ram.xml)
 - Volume keys now have a fallback that re-assign new keys
 - The installer now has an option to automatically install recommended settings

common/adaptive_audio.sh

@@ -17,7 +17,7 @@ if [ -f "$MusicDetector_location" ] &&
 
   # Adding flags
   ui_print ' [+] Adding flags...'
-  insert_gms_features "FlagOverrides" $packageName 0 null 1 null null 0 "Echo__enable_headphones_suggestions_from_agsa" "Echo__smartspace_enable_doorbell" "Echo__smartspace_enable_earthquake_alert_predictor" "Echo__smartspace_enable_echo_settings" "Echo__smartspace_enable_light_predictor" "Echo__smartspace_enable_paired_device_predictor" "Echo__smartspace_enable_safety_check_predictor" "NowPlaying__ambient_music_on_demand_enabled" "NowPlaying__cloud_api_allowed" "NowPlaying__enable_usage_fa" "NowPlaying__favorites_enabled" "NowPlaying__handle_ambient_music_results_with_history" "NowPlaying__youtube_export_enabled" "Overview__enable_lens_r_overview_long_press" "Overview__enable_lens_r_overview_select_mode" "Overview__enable_lens_r_overview_translate_action"
+  insert_gms_features "FlagOverrides" $packageName 0 null 1 null null 1 "Echo__enable_headphones_suggestions_from_agsa" "Echo__smartspace_enable_doorbell" "Echo__smartspace_enable_earthquake_alert_predictor" "Echo__smartspace_enable_echo_settings" "Echo__smartspace_enable_light_predictor" "Echo__smartspace_enable_paired_device_predictor" "Echo__smartspace_enable_safety_check_predictor" "NowPlaying__ambient_music_on_demand_enabled" "NowPlaying__cloud_api_allowed" "NowPlaying__enable_usage_fa" "NowPlaying__favorites_enabled" "NowPlaying__handle_ambient_music_results_with_history" "NowPlaying__youtube_export_enabled" "Overview__enable_lens_r_overview_long_press" "Overview__enable_lens_r_overview_select_mode" "Overview__enable_lens_r_overview_translate_action"
 
   # Done
   ui_print " [✓] Installed"

common/addon/SQLite3/install.sh

@@ -32,7 +32,7 @@ insert_gms_features() {
   shift # Remove floatVal argument
   [ "$1" ] && stringVal=$1 || stringVal=null
   shift # Remove stringVal argument
-  [ "$1" ] && committed=$1 || committed=0
+  [ "$1" ] && committed=$1 || committed=1
   shift # Remove committed argument
 
   # Make sure database is open
@@ -53,11 +53,11 @@ insert_gms_features() {
     $SQLite3 $gms "DELETE FROM $tableName WHERE packageName='$packageName' AND name='$featureName';"
 
     # Enable feature for system
-    $SQLite3 "$gms" "INSERT INTO $tableName (packageName, flagType, user, name, intVal, boolVal, committed) VALUES ('$packageName', '$flagType', '', '$featureName', '$intVal', '$boolVal', '$committed');"
+    $SQLite3 "$gms" "INSERT INTO $tableName (packageName, flagType, user, name, intVal, boolVal, floatVal, stringVal, committed) VALUES ('$packageName', '$flagType', '', '$featureName', '$intVal', '$boolVal', '$floatVal', '$stringVal', '$committed');"
 
     # Enable feature per account
     for user in $google_accounts; do
-      $SQLite3 "$gms" "INSERT INTO $tableName (packageName, flagType, user, name, intVal, boolVal, committed) VALUES ('$packageName', '$flagType', '$user', '$featureName', '$intVal', '$boolVal', '$committed');"
+      $SQLite3 "$gms" "INSERT INTO $tableName (packageName, flagType, user, name, intVal, boolVal, floatVal, stringVal, committed) VALUES ('$packageName', '$flagType', '$user', '$featureName', '$intVal', '$boolVal', '$floatVal', '$stringVal', '$committed');"
     done
   done
 }

common/gboard.sh

@@ -4,9 +4,9 @@ packageName="com.google.android.inputmethod.latin#com.google.android.inputmethod
 
 if selector "Enable Pixel GBoard Features ?" "$useRecommendedSettings" "Enable" "Disable"; then
   ui_print ' [+] Adding flags...'
-  insert_gms_features "FlagOverrides" $packageName 0 null 1 null null 0 "crank_trigger_decoder_inline_completion_first" "crank_trigger_decoder_inline_prediction_first" "enable_core_typing_experience_indicator_on_candidates" "enable_core_typing_experience_indicator_on_composing_text" "enable_email_provider_completion" "enable_floating_keyboard_v2" "enable_inline_suggestions_on_client_side" "enable_inline_suggestions_on_decoder_side" "enable_inline_suggestions_space_tooltip" "enable_inline_suggestions_tooltip_v2" "enable_matched_predictions_as_inline_from_crank_cifg" "enable_multiword_predictions_as_inline_from_crank_cifg" "enable_multiword_predictions_from_user_history" "enable_multiword_suggestions_as_inline_from_crank_cifg" "enable_next_generation_hwr_support" "enable_nga" "enable_single_word_predictions_as_inline_from_crank_cifg" "enable_single_word_suggestions_as_inline_from_crank_cifg" "enable_user_history_predictions_as_inline_from_crank_cifg" "nga_enable_mic_button_when_dictation_eligible" "nga_enable_mic_onboarding_animation" "nga_enable_spoken_emoji_sticky_variant" "nga_enable_sticky_mic" "nga_enable_undo_delete" "silk_on_all_devices" "silk_on_all_pixel"
-  insert_gms_features "FlagOverrides" $packageName 0 4 null null null 0 "inline_suggestion_experiment_version"
-  insert_gms_features "FlagOverrides" $packageName 0 1 null null null 0 "user_history_learning_strategies"
+  insert_gms_features "FlagOverrides" $packageName 0 null 1 null null 1 "crank_trigger_decoder_inline_completion_first" "crank_trigger_decoder_inline_prediction_first" "enable_core_typing_experience_indicator_on_candidates" "enable_core_typing_experience_indicator_on_composing_text" "enable_email_provider_completion" "enable_floating_keyboard_v2" "enable_inline_suggestions_on_client_side" "enable_inline_suggestions_on_decoder_side" "enable_inline_suggestions_space_tooltip" "enable_inline_suggestions_tooltip_v2" "enable_matched_predictions_as_inline_from_crank_cifg" "enable_multiword_predictions_as_inline_from_crank_cifg" "enable_multiword_predictions_from_user_history" "enable_multiword_suggestions_as_inline_from_crank_cifg" "enable_next_generation_hwr_support" "enable_nga" "enable_single_word_predictions_as_inline_from_crank_cifg" "enable_single_word_suggestions_as_inline_from_crank_cifg" "enable_user_history_predictions_as_inline_from_crank_cifg" "nga_enable_mic_button_when_dictation_eligible" "nga_enable_mic_onboarding_animation" "nga_enable_spoken_emoji_sticky_variant" "nga_enable_sticky_mic" "nga_enable_undo_delete" "silk_on_all_devices" "silk_on_all_pixel"
+  insert_gms_features "FlagOverrides" $packageName 0 4 null null null 1 "inline_suggestion_experiment_version"
+  insert_gms_features "FlagOverrides" $packageName 0 1 null null null 1 "user_history_learning_strategies"
 
   # Done
   ui_print " [✓] Installed"

common/google_dialer.sh

@@ -4,13 +4,14 @@ packageName="com.google.android.dialer"
 
 if selector "Enable Pixel Google Dialer Features ?" "$useRecommendedSettings" "Enable" "Disable"; then
   ui_print ' [+] Adding flags...'
-  insert_gms_features "FlagOverrides" $packageName 0 null 1 null null 0 "enable_theme_pushing" "enable_precall_dialpad_v2" "enable_dialpad_v2_ux" "CallLogInformationArchitecture__enable_call_log_information_architecture" "CallRecording__enable_call_recording_for_fi" "G__always_enable_new_call_log_framework_and_fragment" "G__are_embeddings_jobs_enabled" "G__bypass_revelio_roaming_check" "G__config_caller_id_enabled" "G__enable_atlas" "G__enable_call_recording" "G__enable_call_screen_audio_stitching" "G__enable_call_screen_data_in_call_log" "G__enable_call_screen_saving_audio" "G__enable_embedding_spam_revelio" "G__enable_new_voicemail_tab" "G__enable_patronus_spam" "G__enable_reject_embedding_spam_calls" "G__enable_revelio" "G__enable_revelio_on_bluetooth" "G__enable_revelio_on_wired_headset" "G__enable_revelio_r_api" "G__enable_spam_blocking_promo" "G__enable_speakeasy_details" "G__enable_wifi_calling_icons_all_carriers" "G__force_disable_enriched_call" "G__force_within_call_recording_geofence_value" "G__force_within_crosby_geofence_value" "G__is_call_log_item_anim_null" "G__new_call_log_fragment_enabled" "G__show_call_screen_recording_player_in_call_log" "G__speak_easy_bypass_locale_check" "G__speak_easy_enable_listen_in_button" "G__speak_easy_enabled" "G__speak_easy_use_soda_asr" "G__use_call_recording_geofence_overrides" "G__voicemail_change_greeting_enabled" "Scooby__are_spam_jobs_enabled" "Scooby__enable_same_prefix_logging" "atlas_use_soda_for_transcription" "enable_android_s_notifications" "enable_atlas_on_tidepods_voice_screen" "enable_dialer_hold_handling" "enable_hold_detection" "enable_revelio_transcript" "enable_smart_reply" "enable_stir_shaken_call_log" "enable_video_call_landscape" "enable_video_handover_dialog" "enable_xatu" "enable_xatu_music_detection" "show_atlas_hold_for_me_confirmation_dialog"
-  insert_gms_features "FlagOverrides" $packageName 0 null 0 null null 0 "G__enable_pride_month_celebration" "G__enable_primes" "G__enable_primes_crash_metric" "G__enable_primes_timer_metric" "G__enable_tidepods_video" "enable_profile_photo_for_on_hold_video_call"
+  insert_gms_features "FlagOverrides" $packageName 0 null 1 null null 1 "CallLogInformationArchitecture__enable_call_log_information_architecture" "CallRecording__enable_call_recording_for_fi" "G__always_enable_new_call_log_framework_and_fragment" "G__answer_false_touch_detection_enabled" "G__are_embeddings_jobs_enabled" "G__bypass_revelio_roaming_check" "G__call_screen_audio_listener_enabled" "G__config_caller_id_enabled" "G__enable_after_call_spam_blocking_promo" "G__enable_atlas" "G__enable_call_recording" "G__enable_call_screen_audio_stitching" "G__enable_call_screen_data_in_call_log" "G__enable_call_screen_saving_audio" "G__enable_duplicates_promo_v2_ui" "G__enable_embedding_spam_revelio" "G__enable_embedding_spam_revelio" "G__enable_new_voicemail_tab" "G__enable_patronus_spam" "G__enable_pendingcall" "G__enable_phone_number_classification_spam" "G__enable_reject_embedding_spam_calls" "G__enable_revelio" "G__enable_revelio_on_bluetooth" "G__enable_revelio_on_wired_headset" "G__enable_revelio_r_api" "G__enable_rtt_visibility_setting_part2" "G__enable_spam_blocking_promo" "G__enable_speak_easy_is_spam_survey" "G__enable_speakeasy_details" "G__enable_video_share" "G__enable_wifi_calling_icons_all_carriers" "G__force_disable_enriched_call" "G__force_within_call_recording_geofence_value" "G__force_within_crosby_geofence_value" "G__is_call_log_item_anim_null" "G__new_call_log_fragment_enabled" "G__new_voicemail_fragment_enabled" "G__show_call_screen_recording_player_in_call_log" "G__speak_easy_bypass_locale_check" "G__speak_easy_enable_listen_in_button" "G__speak_easy_enabled" "G__speak_easy_use_soda_asr" "G__use_call_recording_geofence_overrides" "G__voicemail_change_greeting_enabled" "G_answer_proximity_sensor_enabled" "G_call_screen_audio_listener_enabled" "Scooby__are_spam_jobs_enabled" "Scooby__enable_same_prefix_logging" "atlas_use_soda_for_transcription" "enable_android_s_notifications" "enable_atlas_on_tidepods_voice_screen" "enable_dialer_hold_handling" "enable_dialpad_v2_ux" "enable_hold_detection" "enable_precall_dialpad_v2" "enable_revelio_transcript" "enable_smart_reply" "enable_stir_shaken_call_log" "enable_theme_pushing" "enable_video_call_landscape" "enable_video_handover_dialog" "enable_voice_autofill" "enable_xatu" "enable_xatu_music_detection" "force_flip_to_silence" "show_atlas_hold_for_me_confirmation_dialog"
+  insert_gms_features "FlagOverrides" $packageName 0 null 0 null null 1 "G__enable_pride_month_celebration" "G__enable_primes" "G__enable_primes_crash_metric" "G__enable_primes_timer_metric" "G__enable_tidepods_video" "enable_profile_photo_for_on_hold_video_call"
+  insert_gms_features "FlagOverrides" $packageName 0 null null null "" 1 "CallRecording__call_recording_countries" "CallRecording__call_recording_countries_with_built_in_audio_file" "CallRecording__call_recording_force_enable_built_in_audio_file_countries" "CallRecording__call_recording_force_enable_tts_countries" "CallRecording__crosby_countries" "G__assisted_dialing_csv_country_codes"
 
   # Done
   ui_print " [✓] Installed"
   ui_print ''
 else
-  ui_print " [~] Ignoring Google Dialer Call Recording"
+  ui_print " [~] Removing from module"
   ui_print ''
 fi

common/install.sh

@@ -35,6 +35,13 @@ if [ "$(grep MemTotal /proc/meminfo | tr -dc '0-9')" -le "6000000" ]; then
   rm -rf "$MODPATH/system/product/etc/sysconfig/*6gb*.xml"
 fi
 
+# Crashing on boot
+if [ "$API" -lt 31 ]; then
+  ui_print " [!] (SDK) Safely removing privapp permissions xml..."
+  ui_print ''
+  rm -rf "$MODPATH"/system/product/etc/permissions/privapp-permissions-google-p.xml
+fi
+
 # Running installer addins
 for addin in "$MODPATH"/common/*.sh; do
   if [ "$addin" != "$MODPATH"/common/install.sh ]; then

customize.sh

@@ -12,7 +12,7 @@ chmod 0644 "$MODPATH/system/product/app/*/*.apk"
 # Remove comments from files and place them, add blank line to end if not already present
 for file in $(find "$MODPATH" -type f -name "*.sh" -o -name "*.prop" -o -name "*.rule"); do
   [ -f "$file" ] && {
-    sed -i -e "/^#/d" -e "/^ *$/d" "$file"
+    sed -i -e "/#/d" -e "/^ *$/d" "$file"
     [ "$(tail -1 "$file")" ] && echo "" >>"$file"
   }
 done

module.prop

@@ -1,7 +1,7 @@
 id=Pixel_Features
 name=Pixel Features
-version=2022-02-28
-versionCode=22022801
+version=2022-03-03
+versionCode=22030300
 author=Tesla
 description=A mix of files from the Pixel Phones to unlock the full potential of Android
 updateJson=https://raw.githubusercontent.com/Pixel-Props/pixel.features/main/update.json