Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the error output for calling pixel graph function with non-existing component name #197

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ptajvar
Copy link
Contributor

@ptajvar ptajvar commented Nov 5, 2024

graph = pxl.graph("missing_component_id") results in a ComputeError instead of a KeyError.

Fixes: EXE-2058

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The tutorial example that was raising a ComputeError raises a KeyError now.

PR checklist:

  • This comment contains a description of changes (with reason).
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@ptajvar ptajvar requested a review from johandahlberg November 5, 2024 17:02
@ptajvar ptajvar merged commit 9834f48 into dev Nov 6, 2024
14 checks passed
@ptajvar ptajvar deleted the fix/exe-2058-graph-error-for-missing-component branch November 6, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants