Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/exe 2075 fail if hard and dynamic size limits are both set #200

Merged

Conversation

johandahlberg
Copy link
Contributor

Description

Fail if both dynamic and hard size limits are set in annotate at the same time.

Fixes: exe-2075

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested by manually running the cli.

PR checklist:

  • This comment contains a description of changes (with reason).
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If a new tool or package is included, I have updated poetry.lock, and cited it properly
  • I have checked my code and documentation and corrected any misspellings
  • I have documented any significant changes to the code in CHANGELOG.md

Copy link
Contributor

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@johandahlberg johandahlberg merged commit 542cc28 into dev Dec 10, 2024
14 checks passed
@johandahlberg johandahlberg deleted the feature/exe-2075-fail-if-hard-and-dynamic-limit-both-set branch December 10, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants