Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable native payments #447

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Enable native payments #447

merged 9 commits into from
Jan 15, 2024

Conversation

prachigarg19
Copy link
Collaborator

@prachigarg19 prachigarg19 commented Nov 9, 2023 •
edited by mohitb35
Loading

  1. Enables native payments using env variables ENABLE_GOOGLE_PAY & ENABLE_APPLE_PAY
  2. Resolves repeated trigger of onPaymentFunction while making payments using Google / Apple Pay
  3. Resolves issue with incorrect initial value seen in Google/Apple Pay dialog when moving between projects

Pending

  • Remove console logs of payment request
  • Set up env vars for production server

@vercel Vercel
Copy link

vercel bot commented Nov 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
donate-with-planet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 4:20am

@prachigarg19 prachigarg19 marked this pull request as draft November 9, 2023 11:45
@norbertschuler norbertschuler force-pushed the feature/enable-native-payments branch from 198a9f9 to de0c599 Compare December 7, 2023 15:22
@norbertschuler
Copy link
Collaborator

norbertschuler commented Dec 29, 2023 •
edited
Loading

  • Google Pay seems to work on Chrome on MacOS
  • Apple Pay seems to work on Safari on MacOS
  • Google Pay on a mobile device was not tested yet by me
  • Apple Pay seems to work on Safari on iPhone/iOS
  • Apple Pay seems to work on an iPhone with Chrome browser!

@mohitb35
fix: initializespaymentRequest on project change
057c639 
- `paymentRequest` initialized on initial render of `PaymentRequestCustomButton`
@mohitb35 mohitb35 marked this pull request as ready for review January 9, 2024 02:16
norbertschuler
norbertschuler approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@norbertschuler norbertschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code changes are fine. I just could not test Apple Pay (compare Slack) :-(

@mohitb35 mohitb35 force-pushed the feature/enable-native-payments branch from 021caca to 4b481bd Compare January 12, 2024 07:51
@mohitb35
feat: conditionally prevent redirect to VERCEL_URL
5bbb787 
- redirect prevented if env.DISABLE_VERCEL_REDIRECT is true
@mohitb35 mohitb35 force-pushed the feature/enable-native-payments branch from 4b481bd to 5bbb787 Compare January 12, 2024 08:55
@mohitb35
feat: disables native payments by default
6887189 
- requires explicit enabling of native payments
mariahosfeld
mariahosfeld reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@mariahosfeld mariahosfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple Pay is now visible to me on mobile, have not yet tested complete functionality.

@mariahosfeld mariahosfeld merged commit 67b1d1b into develop Jan 15, 2024
6 checks passed
@mariahosfeld mariahosfeld deleted the feature/enable-native-payments branch January 15, 2024 08:30
@mariahosfeld mariahosfeld mentioned this pull request Jan 15, 2024
Merged
@mohitb35 mohitb35 mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariahosfeld mariahosfeld mariahosfeld left review comments

@norbertschuler norbertschuler norbertschuler approved these changes

@sagararyal sagararyal Awaiting requested review from sagararyal

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prachigarg19 @norbertschuler @mariahosfeld @mohitb35