Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Giftable donations #473

Merged
merged 35 commits into from
Dec 3, 2024
Merged

Release Giftable donations #473

merged 35 commits into from
Dec 3, 2024

Conversation

mariahosfeld
Copy link
Contributor

@mariahosfeld mariahosfeld commented Dec 3, 2024 •
edited by mohitb35
Loading

mohitb35 and others added 29 commits November 12, 2024 11:36
@mohitb35
feat: enhance project details types with classification & purpose var…
e80151a 
…iations
@mohitb35
feat: refactor project details handling with createProjectDetails uti…
330aeda 
…lity

- also populates `classification` in projectDetails
@mohitb35
feat: update GiftForm display logic
4827176 
- based on project classification and frequency
@mohitb35
feat: removes unneeded GiftForm fields for membership projects
e508a6f
@mohitb35
feat: refine DonationsForm gift handling while paying through planet …
56a6baa 
…cash

- explicitly sets `gift` based on type
@mohitb35
feat: prevent initialization of direct gift for membership projects
562fa92
@mohitb35
feat: rename projectDetails classification to category
66552ec
@mohitb35
feat: prevent GiftForm display for planet-cash donations
09ccd93
@mohitb35
fix: remove unneeded onBehalf while creating prepaid donation
10fbef4
@mohitb35
feat: prevent gifts to non giftable project purposes
fa0c770 
- bouquet and planet-cash
@mohitb35
feat: update gift message to clarify dedication to recipient
9ca3909
@mohitb35
chore: update @planet-sdk/common to version 0.1.42
92d62ab
@mohitb35
feat: remove support link from query params when not applicable
62b38ac
@mohitb35
feat: update gift types and usage to resolve TS warnings
416b7a4 
- giftDetails stored in context is now of type `GiftDetails`
- `SentGift` is used purely for the API request data
- updates types and type guards through the app
@mohitb35
feat: ensure donation amounts are treated as numbers for consistency
ed270b3
@mohitb35
fix: standardize casing for setIsGift
dd2b8e3
@mohitb35
revert: rename projectDetails category to classification for cons…
e84df9b 
…istency
@mohitb35
refactor: remove conditional onBehalf donor assignment in DonationsForm
448c65d
@mohitb35
fix: minor code cleanup and fixes
fb98cd9
@mohitb35
fix: fixes visible currency selector for non tree donations while dis…
bc4af28 
…playing gift form
@mohitb35
fix: resolves intermittent layout issue with MaterialTextField
83e1544
@mohitb35
fix: add validation for recipient name length in GiftForm
c379166
@mohitb35
feat: update logic to show PlanetCashSelector
2890661 
- refactors code to extract logic to show `PlanetCashSelector` to `isPlanetCashAllowed` utility function
@mohitb35
refactor: remove unused _onBehalfDonor assignment in DonationsForm
071785c
@mohitb35
feat: add check for PlanetCash gateway while permitting planet cash d…
2839bc1 
…onations
@mohitb35
feat: add authentication to loadPaymentSetup
2eced0a 
- adds authentication to loadPaymentSetup call (as "planet-cash" gateway is only returned in authenticated call)
- adds debouncing while loading payment setup for non planet cash projects
@mariahosfeld
Merge pull request #471 from Plant-for-the-Planet-org/feature/expand-…
b7cb75c 
…planetcash-usage

Allow PlanetCash payments for more types of donations
@mariahosfeld
Merge pull request #472 from Plant-for-the-Planet-org/feature/restric…
8546ebb 
…t-gift-recipient-name-length

Add validation for recipient name length in GiftForm
@mariahosfeld
Merge pull request #470 from Plant-for-the-Planet-org/feature/giftabl…
2a71cb1 
…e-donations

Giftable donations
@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
donate-with-planet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 11:53am

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

mohitb35
mohitb35 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mohitb35 mohitb35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lingohub bot and others added 3 commits December 3, 2024 10:53
@lingohub
Language update from Lingohub 🤖
088cd7b 
Project Name: Planet Donations
Project Link: https://app.lingohub.com/project/pr_172KiVj7Kgme-15987/branches/prb_17xeXktPDPZl-3890
User: Maria Hosfeld

Easy language translations with Lingohub 🚀
@mariahosfeld
Merge pull request #474 from Plant-for-the-Planet-org/lingohub_langua…
90d2774 
…ge_update_2024-12-03Z

Language update from Lingohub 🤖 on 2024-12-03Z
@mohitb35
chore: update @planet-sdk/common to version 0.1.47
99e0b3b
@mohitb35
fix: correct typos for getFormattedCurrency / getFormattedCurrencySymbol
71554b5
@mohitb35
refactor: minor refactors to address codefactor feedback
f2574c1 
- removes unnecessary `true &&...` expression
- refactors onClick handler for currency selector in TreeDonations
@mohitb35
Merge pull request #475 from Plant-for-the-Planet-org/hotfix/typos-an…
0f124bf 
…d-planet-sdk-update

Update @planet-sdk/common and fix typos in currency functions
@mariahosfeld mariahosfeld merged commit 0892f98 into main Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohitb35 mohitb35 mohitb35 approved these changes

@sunilsabatp sunilsabatp Awaiting requested review from sunilsabatp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariahosfeld @mohitb35