Fix create pool issues

[AMIRKHANEF]

Works Done

1. Fix loop issue: by removing estimatedFee from inputs (because in the review page estimatedFee one more time will be fetched no problems will be happen).
2. Pool name can not be set empty.
3. some small refactors: (a duplicate useEffect eliminated, ...).

Close #1330

Summary by CodeRabbit

• New Features

  • Improved pool creation form with enhanced validation and handling of inputs.

• Refactor

  • Optimized logic for disabling review button based on more comprehensive conditions.

[coderabbitai]

Walkthrough

The primary changes in the index.tsx file involve reorganizing hook imports, adding a new useBalances hook, and enhancing the toReviewDisabled logic to include more conditions for disabling. Additionally, the DEFAULT_POOLNAME calculation and the handling of metadata in the setInputs function have been refined to ensure pool names cannot be empty.

Changes

Files/Paths	Change Summary
packages/extension-polkagate/src/fullscreen/stake/pool/create/index.tsx	Reorganized hook imports, added useBalances, refactored toReviewDisabled logic, adjusted DEFAULT_POOLNAME calculation, and improved metadata handling in setInputs.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant Hooks
    participant PoolCreationLogic

    User->>UI: Enter Pool Details
    UI->>Hooks: Fetch Balances (useBalances)
    UI->>PoolCreationLogic: Validate Inputs
    PoolCreationLogic->>UI: Update `toReviewDisabled` Status
    UI->>User: Display Updated Pool Creation Form

Loading

Assessment against linked issues

Objective (Issue #1330)	Addressed	Explanation
Pool name can be empty	✅
Loop issue	❓	The summary does not mention a specific loop fix.

Poem

In the code where pools are made,
A balance hook now lends its aid.
No nameless pools shall slip through,
With logic tweaked and checks anew.
A smoother path for staking's call,
Ensuring clarity for one and all.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dc124ae and 201ad56.

Files selected for processing (1)

• packages/extension-polkagate/src/fullscreen/stake/pool/create/index.tsx (6 hunks)

Additional context used

Biome

packages/extension-polkagate/src/fullscreen/stake/pool/create/index.tsx

[error] 148-148: This hook does not specify all of its dependencies: bouncerId (lint/correctness/useExhaustiveDependencies)

This dependency is not specified in the hook dependency list.

---

[error] 148-148: This hook does not specify all of its dependencies: nominatorId (lint/correctness/useExhaustiveDependencies)

This dependency is not specified in the hook dependency list.

Additional comments not posted (7)

packages/extension-polkagate/src/fullscreen/stake/pool/create/index.tsx (7)

13-13: Added useBalances hook to the import list.

This aligns with the AI-generated summary and enhances the functionality by fetching the available balance.

---

31-31: Usage of useBalances to fetch the available balance.

This is a good use of the newly added hook, ensuring that the balance is fetched dynamically.

---

47-47: Refactored DEFAULT_POOLNAME to include dynamic pool ID.

This change makes the default pool name more informative and dynamic, aligning with the PR's refactoring objectives.

---

50-58: Enhanced toReviewDisabled logic to include additional conditions.

This modification ensures a more robust validation before proceeding to the review stage, which is crucial for data integrity.

---

85-85: Added callback for handling pool name changes.

This change ensures that the pool name cannot be set to empty, addressing a specific issue mentioned in the linked GitHub issue.

---

Line range hint 119-146: Adjusted handling of metadata in the setInputs function.

This adjustment ensures that the pool metadata is set correctly, which is crucial for the creation process.

Tools

Biome

[error] 148-148: This hook does not specify all of its dependencies: bouncerId (lint/correctness/useExhaustiveDependencies)

This dependency is not specified in the hook dependency list.

---

[error] 148-148: This hook does not specify all of its dependencies: nominatorId (lint/correctness/useExhaustiveDependencies)

This dependency is not specified in the hook dependency list.

---

146-146: This hook does not specify all of its dependencies: bouncerId, nominatorId.

The dependencies bouncerId and nominatorId are missing from the dependency array of the useEffect hook, which can lead to stale data issues.

- }, [DEFAULT_POOLNAME, amountAsBN, api, createAmount, formatted, poolName, poolStakingConsts?.lastPoolId, setInputs]);
+ }, [DEFAULT_POOLNAME, amountAsBN, api, bouncerId, createAmount, formatted, nominatorId, poolName, poolStakingConsts?.lastPoolId, setInputs]);

Likely invalid or redundant comment.