clustering coefficient update #1909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
requested changes
Jan 13, 2025
There was a problem hiding this comment.
- the path-based algorithm has room for optimisation
- we need a benchmark to decide whether it is worth keeping the set-based algorithm at all
- the filtering of nodes for the batch versions is unnecessarily inefficient (no need for creating subgraph views)
- python wrappers should raise proper errors instead of panicking
...algorithms/metrics/clustering_coefficient/local_clustering_coefficient_batch_intersection.rs
Outdated
Show resolved
Hide resolved
...ory/src/algorithms/metrics/clustering_coefficient/local_clustering_coefficient_batch_path.rs
Outdated
Show resolved
Hide resolved
...ory/src/algorithms/metrics/clustering_coefficient/local_clustering_coefficient_batch_path.rs
Outdated
Show resolved
Hide resolved
...ory/src/algorithms/metrics/clustering_coefficient/local_clustering_coefficient_batch_path.rs
Outdated
Show resolved
Hide resolved
ljeub-pometry
requested changes
Jan 27, 2025
| .iter() | ||
| .filter(|nbor| nbor.degree() > 1 && nbor.node != s.node) | ||
| .combinations(2) | ||
| .filter_map(|nb| match graph.has_edge(nb[0].node, nb[1].node) { |
There was a problem hiding this comment.
a simple filter(|nb| graph.has_edge(nb[0].node, nb[1].node) || graph.has_edge(nb[1].node, nb[0].node)) would do the same
Comment on lines
73
to
79
|
|
||
| // let mut ctx: Context<G, ComputeStateVec> = graph.into(); | ||
| let neighbours_set = accumulators::hash_set::<VID>(0); | ||
| //let neighbours_set = accumulators::hash_set::<VID>(0); | ||
| let count = accumulators::sum::<usize>(1); | ||
|
|
||
| ctx.agg(neighbours_set); | ||
| //ctx.agg(neighbours_set); | ||
| ctx.global_agg(count); |
| if let Ok(py_list) = param.downcast::<PyList>() { | ||
| let mut nodes = Vec::new(); | ||
| for item in py_list.iter() { | ||
| // Extract each item as a float |
There was a problem hiding this comment.
that's a node, not a float
There was a problem hiding this comment.
these files should not be committed
There was a problem hiding this comment.
these files should not be committed
There was a problem hiding this comment.
these files should not be committed
There was a problem hiding this comment.
these files should not be committed
There was a problem hiding this comment.
these files should not be committed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor global and local clustering coefficient.
Add two variants of batch local clustering coefficient.Added a single, optimised version.Why are the changes needed?
It's currently extremely inefficient to run LCC on a group of nodes. The batch version should do a better job of parallelizing the process and reducing overhead.
Does this PR introduce any user-facing change? If yes is this documented?
'clustering_coefficient' is renamed to 'global_clustering_coefficient'. All of the clustering coefficient variants have been moved to a submodule of 'metrics' called 'clustering_coefficient'. The new batch implementation has corresponding docstrings.
How was this patch tested?
The two methods wereThe new method was tested for parity against the existing implementation in Rust and Python.Are there any further changes required?
Currently working on an approximate version that uses HyperLogLog.