Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create NotesKeywordHighlighter.bambda #39

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Create NotesKeywordHighlighter.bambda #39

merged 4 commits into from
Dec 13, 2023

Conversation

BugBountyzip
Copy link
Contributor

@BugBountyzip BugBountyzip commented Dec 12, 2023 •
edited
Loading

NotesKeywordHighlighter.bambda

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

Tired of playing hide and seek with your HTTP history notes?

Demo :

image

No more note nightmares, just highlight delights! 🎉

@BugBountyzip
Create NotesKeywordHighlighter.bambda
adb9dc6 
NotesKeywordHighlighter.bambda
@BugBountyzip
Copy link
Contributor Author

Searching with a specific note in both Community and Professional editions was just a dream?

Well, dream no more!

PortSwiggerWiener
PortSwiggerWiener requested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission.

Looks good! I've added a couple of suggestions.

Proxy/HTTP/NotesKeywordHighlighter.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/NotesKeywordHighlighter.bambda Outdated Show resolved Hide resolved
ps-porpoise
ps-porpoise approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@ps-porpoise ps-porpoise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

PortSwiggerWiener
PortSwiggerWiener approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your patience during the review process.

Looks good 👍

@PortSwiggerWiener PortSwiggerWiener merged commit 054ce3d into PortSwigger:main Dec 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-porpoise ps-porpoise ps-porpoise approved these changes

@PortSwiggerWiener PortSwiggerWiener PortSwiggerWiener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BugBountyzip @PortSwiggerWiener @ps-porpoise