-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bambda to filter authorization values not equal to jwt bearer #61
feat: Bambda to filter authorization values not equal to jwt bearer #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your submission!
We have some feedback points for you.
Please let us know if you have any questions, or if there's anything we can help with.
i received some errors when simply removing the ternary so resulted in using casting instead
Thanks @Hannah-PortSwigger ! I performed individual commit's to address your feedback above and tested to ensure this is working with no errors following the changes (see a few only outstanding topic is within this comment but apart from that i think we maybe good to 🧻 ? plmk if you need anything else, tyia! |
@GangGreenTemperTatum Thanks for taking a look! We've made some further adjustments based on the feedback to tidy up the Bambda a bit - can you check whether this still lines up with your original logic? |
hey @Hannah-PortSwigger , thanks for the constructive feedback! yes, this still sems to align with my bambda purpose and intention. also, to double-check i also tested again against my proxy history and matches my intended results with no errors: plmk if you need anything else, tyia! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for your submission!
Bambda Contributions
@author
annotation and suitable descriptionThe intent of this bambda is to filter the burp suite proxy for in-scope HTTP requests that contain an
Authorization
HTTP header which!=null
, contains "bearer
" (case-insensitive) and!~"ey"
.The JWT header often (not always) starts with {"alg":... , which then becomes eyJ... of course, this can be expanded to tailor other types of session-tokens etc.
The use-case for this (which i have tested and used myself) is for testing web app endpoints which use authentication, but is not validated with a traditional bearer token such as JWT (could be an API key for example) which can represent incoherence and weaknesses within endpoint security misconfigurations between the use of session-tokens and API keys for authentication.
Here's an example of my bambda in action:
The goal of identifying web application endpoints that use authentication but are not validated with a traditional bearer token (e.g., JWT or API key) is important for several reasons in terms of application security: