Create DetectCSPReportOnlyHeader.bambda #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script checks if the HTTP response contains the "Content-Security-Policy-Report-Only" header, which is used for monitoring CSP violations without enforcing restrictions.
Hannah-PortSwigger
requested changes
Jan 2, 2025
| requestResponse.response().headers().stream() | ||
| .anyMatch(header -> | ||
| header.name().equalsIgnoreCase("Content-Security-Policy-Report-Only") && | ||
| header.value().toLowerCase().contains("report-uri") |
There was a problem hiding this comment.
Please can you set Locale.US in the toLowerCase function? Some locales can mangle the data when converting to lower case.
| // Check for Content-Security-Policy-Report-Only header | ||
| requestResponse.response().headers().stream() | ||
| .anyMatch(header -> | ||
| header.name().equalsIgnoreCase("Content-Security-Policy-Report-Only") |
There was a problem hiding this comment.
Is there a particular reason you are using case-insensitive matching rather than the built-in hasHeader() functionality on HttpResponse?
| requestResponse.response().headers().stream() | ||
| .anyMatch(header -> | ||
| header.name().equalsIgnoreCase("Content-Security-Policy-Report-Only") | ||
| ) && |
There was a problem hiding this comment.
It looks like you're checking for the "Content-Security-Policy-Report-Only" header twice. Could you refine this further? For example, adding an initial config option to determine whether you are just checking for the presence of the header, or whether you are checking for presence of the specific value with the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script checks if the HTTP response contains the "Content-Security-Policy-Report-Only" header, which is used for monitoring CSP violations without enforcing restrictions.
Bambda Contributions
@authorannotation and suitable description