Fix update tag script to checkout to the target branch

PostHog · Nov 3, 2023 · 9da6692 · 9da6692
1 parent f6739de
commit 9da6692
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -31,13 +31,11 @@ jobs:
 
       - name: Commit & push
         run: |
-          echo "Tag name from github.ref_name: ${{ github.event.release.target_commitish }}"
           ./scripts/commit-code.sh ${{ github.event.release.target_commitish }}
 
       - name: Update tag
         run: |
-          echo "Tag name from github.ref_name: ${{ github.event.release.tag_name }}"
-          ./scripts/update-tag.sh ${{ github.event.release.tag_name }}
+          ./scripts/update-tag.sh ${{ github.event.release.tag_name }} ${{ github.event.release.target_commitish }}
   
       - name: Release
         run: make releaseCocoaPods
diff --git a/scripts/update-tag.sh b/scripts/update-tag.sh
@@ -3,12 +3,13 @@ set -euo pipefail
 
 CURRENT_TAG="$1"
 TEMP_TAG="${CURRENT_TAG}-temp"
+GITHUB_BRANCH="${2}"
 
 echo "Going to push the tag changes."
 git config --global user.name 'PostHog Github Bot'
 git config --global user.email '[email protected]'
 git fetch
-git checkout ${CURRENT_TAG}
+git checkout ${GITHUB_BRANCH}
 # Create a new temporary tag after pushing the changes from the previous tag (bump version)
 git tag -a ${TEMP_TAG} -m "${TEMP_TAG}"
 # Remove the current tag