Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session replay forces the session id if the SDK is already enabled #307

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Nov 15, 2024

Problem

for some reason, sometimes but not so rarely, the recording does not have associated events but the SDK did capture events, and the session id does not match.
I believe the SDK can be already enabled or the session id rotated wrongly in the native SDK.
Now the hybrid SDK fully controls the session id lifecycle and if the SDK is somehow already enabled, we force the session id again.
Depends on PostHog/posthog-ios#253 as well

Changes

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

  • Added support for X

@marandaneto marandaneto requested a review from a team November 15, 2024 15:09
Copy link

github-actions bot commented Nov 18, 2024

Size Change: +71 B (+0.07%)

Total Size: 106 kB

Filename Size Change
posthog-react-native/lib/posthog-react-native/src/posthog-rn.js 4.08 kB +70 B (+1.75%)
posthog-react-native/lib/posthog-react-native/src/version.js 124 B +1 B (+0.81%)
ℹ️ View Unchanged
Filename Size
posthog-node/lib/index.cjs.js 20 kB
posthog-node/lib/index.esm.js 20 kB
posthog-react-native/lib/posthog-core/src/eventemitter.js 1.08 kB
posthog-react-native/lib/posthog-core/src/index.js 9.72 kB
posthog-react-native/lib/posthog-core/src/lz-string.js 1.42 kB
posthog-react-native/lib/posthog-core/src/types.js 365 B
posthog-react-native/lib/posthog-core/src/utils.js 822 B
posthog-react-native/lib/posthog-core/src/vendor/uuidv7.js 2.04 kB
posthog-react-native/lib/posthog-react-native/index.js 485 B
posthog-react-native/lib/posthog-react-native/src/autocapture.js 1.8 kB
posthog-react-native/lib/posthog-react-native/src/frameworks/wix-navigation.js 651 B
posthog-react-native/lib/posthog-react-native/src/hooks/useFeatureFlag.js 437 B
posthog-react-native/lib/posthog-react-native/src/hooks/useFeatureFlags.js 362 B
posthog-react-native/lib/posthog-react-native/src/hooks/useLifecycleTracker.js 416 B
posthog-react-native/lib/posthog-react-native/src/hooks/useNavigationTracker.js 628 B
posthog-react-native/lib/posthog-react-native/src/hooks/usePostHog.js 249 B
posthog-react-native/lib/posthog-react-native/src/legacy.js 810 B
posthog-react-native/lib/posthog-react-native/src/native-deps.js 1.17 kB
posthog-react-native/lib/posthog-react-native/src/optional/OptionalAsyncStorage.js 183 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoApplication.js 215 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoDevice.js 211 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoFileSystem.js 224 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoLocalization.js 216 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeDeviceInfo.js 220 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeNavigation.js 218 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeNavigationWix.js 222 B
posthog-react-native/lib/posthog-react-native/src/optional/OptionalSessionReplay.js 231 B
posthog-react-native/lib/posthog-react-native/src/PostHogContext.js 210 B
posthog-react-native/lib/posthog-react-native/src/PostHogProvider.js 1.57 kB
posthog-react-native/lib/posthog-react-native/src/storage.js 1.09 kB
posthog-react-native/lib/posthog-react-native/src/types.js 90 B
posthog-web/lib/index.cjs.js 17.1 kB
posthog-web/lib/index.esm.js 17.1 kB

compressed-size-action

@marandaneto marandaneto marked this pull request as ready for review November 18, 2024 07:50
@marandaneto marandaneto enabled auto-merge (squash) November 18, 2024 08:01
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low context 👍

@marandaneto marandaneto merged commit be654a8 into main Nov 18, 2024
4 checks passed
@marandaneto marandaneto deleted the fix/force-sessionid branch November 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants