Feat: Add llm observability to python sdk #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k11kirky
changed the title
Twixes
reviewed
Jan 10, 2025
k11kirky
changed the title
skoob13
reviewed
Jan 10, 2025
| "$ai_model_parameters": get_model_params(kwargs), | ||
| "$ai_input": kwargs.get("messages"), | ||
| "$ai_output": { | ||
| "choices": [ |
There was a problem hiding this comment.
Do we want to send an object here instead of the array with choices directly? We've already flattened the structure with additional fields like input/output tokens, so this might be the output itself.
There was a problem hiding this comment.
Although for most use cases "choices" only has one option, the user can ask the llm for mulitple im which case the choices array represents n options for a response. If we remove the object and just return the array it would look more like the messages array representing a history.
Twixes
reviewed
Jan 10, 2025
| posthog_properties: Optional[Dict[str, Any]] = None, | ||
| **kwargs: Any, | ||
| ): | ||
| distinct_id = posthog_distinct_id or uuid.uuid4() |
There was a problem hiding this comment.
we use 4 in the rest of the repo, so trying to keep it consistant
timgl
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for LLM Observability
example data can be created by exporting the following env vars
python3 llm_observability_examples