Skip to content

Commit

Permalink
tests: Disable waiting for selector
Browse files Browse the repository at this point in the history
Or else the snapshot is never generated because the selector is never found
  • Loading branch information
rafaeelaudibert committed Feb 4, 2025
1 parent 3e7b452 commit 593b946
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,9 @@ export const LoadingMessages: StoryFn = () => {
</ul>
)
}
LoadingMessages.parameters = {
testOptions: {
waitForLoadersToDisappear: false,
waitForSelector: undefined, // Unset the default selector or else this won't ever finish running
},
}
2 changes: 1 addition & 1 deletion frontend/src/scenes/insights/EmptyStates/EmptyStates.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ export function SavedInsightsEmptyState(): JSX.Element {

// show the search string that was used to make the results, not what it currently is
const searchString = insights.filters?.search || null
const { title, description } = SAVED_INSIGHTS_COPY[tab] ?? {}
const { title, description } = SAVED_INSIGHTS_COPY[tab as keyof typeof SAVED_INSIGHTS_COPY] ?? {}

return (
<div
Expand Down

0 comments on commit 593b946

Please sign in to comment.