-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Sidebar - Max #27091
feat: Support Sidebar - Max #27091
Conversation
…so added 1 line to URL validation in the system prompt.
flashy/blinky behavior seen while typing after Max had included a codeblock in a response.
a collapsible, "Explore the docs", because less scrolling is more betterer.
…in the sidepanel instead of in a new tab.
… this commit. Will be pairing with others to revive him.
…n be run on the local with this commit, but can't run Max yet, need to know how to handle secrets correctly.
…ation management, improved token and cache tracking.
…PostHog/posthog into support-sidebar-max-integration
…o anthropic API doesn't work in this commit, pushing it to pair with Michael on it.
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
…PostHog/posthog into support-sidebar-max-integration
Thanks @skoob13 ! Changes made (checks are still running, but I'll revisit if any fail.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Three things:
- requirements.in/txt got lost. We don't have beautifulsoup and Anthropic SDK installed.
- You need to run Ruff locally to pass the CI and commit the format changes:
ruff check --fix
. - Some tests seem to be broken, but it might just be a flaky CI.
and low-priority nits if you have time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename should be snake case. You can use prompt.py because it's already meaningful.
- text blocks for normal conversation | ||
- tool_use blocks for search queries | ||
- tool_result blocks for search results | ||
2. ALWAYSUse XML tags within text blocks for UI display: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should a space be after ALWAYS?
ee/urls.py
Outdated
from ee.api import integration | ||
from ee.support_sidebar_max.views import MaxChatViewSet | ||
from .api.rbac import organization_resource_access, role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some endpoints were removed, so that's why CI fails.
Thanks much @skoob13 , each of those is addressed in the latest commits. Regarding the two checks that did not pass: The python code quality formatting error looks unrelated to my commits (
The Django tests – Core (persons-on-events off) fail looks unrelated as well ( |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Great job!
Co-authored-by: Michael Matloka <[email protected]> Co-authored-by: Georgiy Tarasov <[email protected]>
Problem
Support AI Chat for the support sidebar. Help users help themselves, reduce support ticket volume.
Does this work well for both Cloud and self-hosted?
Cloud only
How did you test this code?
Lots of chatting with Max, in two browsers concurrently.
Feature flag in place for a bit more internal testing before we give access to a small set of customers initially.
Edit: Once this review is done, I'll be submitting another PR for this more recent commit