Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add libxmlsec1 homebrew formula #27323

Closed
wants to merge 2 commits into from
Closed

Conversation

pl
Copy link
Contributor

@pl pl commented Jan 7, 2025

Problem

Installing python packages as prescribed in the handbook fails due to a clash between the xmlsec python package and the most recent version of libxmlsec1 from homebrew.

We can't update the python package, as there are no libxmlsec1 packages for 1.3.x and the latest xmlsec package is not compatible with libxmlsec1 1.2.x.

Changes

Adds a homebrew formula to the repository, so that we can simplify the instructions for developing locally and make sure every time we install the same package.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

Installed the packages into a clean python venv.

TODO

@pl pl requested review from benjackwhite and meikelmosby January 7, 2025 17:52
@pl pl changed the title fix: update xmlsec to 1.3.14 to fix build errors chore: add libxmlsec1 homebrew formula Jan 7, 2025
@@ -0,0 +1,77 @@
class Libxmlsec1 < Formula
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can do this not at the top level? Just having another top level folder is a bit annoying

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@pl
Copy link
Contributor Author

pl commented Jan 20, 2025

Closing, as @mariusandra is working on a much better solution here: #27284

@pl pl closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants