fix: property labels need to be known about in the backend but are defined in the front end #27328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverb123
approved these changes
Jan 7, 2025
…sync them manually
📸 UI snapshots have been updated91 snapshot changes in total. 0 added, 91 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated87 snapshot changes in total. 0 added, 87 modified, 0 deleted:
Triggered by this commit. |
|
Fixes #26923 |
|
tagging @PostHog/team-ai-product-manager since this moves some of their code. i'm not trying to collapse the duplication here, but will follow-up by dumping the dictionaries into the POSTHOG_APP_CONTEXT on window |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
oliverb123
approved these changes
Jan 8, 2025
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
property definition searching depends on a list of aliases being available in the API code
that needs to be manually updated - and we're not updating it so the search breaks
the taxonomy is already duplicated into the ee hogai folder
let's move that into posthog (since it's already not EE licensed in the frontend) and use that in the search
we should collapse the duplication in the front end but we can do that in the future since this is already one step better