feat: promote data warehouse from taxonomic filter component #27364
+108
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
joshsny
commented
Jan 8, 2025
| type="primary" | ||
| icon={<IconPlus />} | ||
| to={action.to} | ||
| data-attr={`taxonomic-filter-empty-state-${groupType}-new-button`} |
There was a problem hiding this comment.
I used a data-attr so we can create an insight for this. From what I could see this is being used elsewhere.
joshsny
requested review from
zlwaterfield and
a team
and removed request for
zlwaterfield
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When creating insights, or in other areas on the product, users are searching for data to filter/view using the
TaxonomicFiltercomponent, sometimes that data isn't available to them yet.Changes
This PR creates an empty state for data warehouse categories that encourages the user to connect sources if they don't have any.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tried out using the taxonomic filter component in a few areas around the product.